* Closed Issue #7 - Option to use a different ActiveRecord class than RestClient#9
Open
larryaasen wants to merge 1 commit into
Open
* Closed Issue #7 - Option to use a different ActiveRecord class than RestClient#9larryaasen wants to merge 1 commit into
larryaasen wants to merge 1 commit into
Conversation
larryaasen
commented
Aug 1, 2013
- Closed Issue Option to use a different ActiveRecord class than RestClient #7 - Option to use a different ActiveRecord class than RestClient
- This update involves a lot of changes to a lot of files, but the functionality remains the same. The change was to rename RestClient to RestAppClient and rest_client to rest_client. This avoids a conflict with the popular rest-client gem that uses the same RestClient class name.
* Closed Issue davesloan#7 - Option to use a different ActiveRecord class than RestClient * This update involves a lot of changes to a lot of files, but the functionality remains the same. The change was to rename RestClient to RestAppClient and rest_client to rest_client. This avoids a conflict with the popular rest-client gem that uses the same RestClient class name.
Owner
|
Thanks for doing this work! I'm concerned, however, that it's not backwards compatible. If someone updates the gem on their API project, this could potentially break a lot of things. I think I'd rather have the option to set the name in the YML file and have a command line option in the generator so on installation, the name can be provided. I welcome your thoughts on this. |
Author
|
Thanks for looking at my code. You make a good point about backwards compatibility. This solution that I provided will break backwards compatibility. Let me look into your idea about setting the class name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.