Skip to content

* Closed Issue #7 - Option to use a different ActiveRecord class than RestClient#9

Open
larryaasen wants to merge 1 commit into
davesloan:masterfrom
larryaasen:name-change
Open

* Closed Issue #7 - Option to use a different ActiveRecord class than RestClient#9
larryaasen wants to merge 1 commit into
davesloan:masterfrom
larryaasen:name-change

Conversation

@larryaasen
Copy link
Copy Markdown

  • Closed Issue Option to use a different ActiveRecord class than RestClient #7 - Option to use a different ActiveRecord class than RestClient
  • This update involves a lot of changes to a lot of files, but the functionality remains the same. The change was to rename RestClient to RestAppClient and rest_client to rest_client. This avoids a conflict with the popular rest-client gem that uses the same RestClient class name.

* Closed Issue davesloan#7 - Option to use a different ActiveRecord class than RestClient
* This update involves a lot of changes to a lot of files, but the functionality remains the same. The change was to rename RestClient to RestAppClient and rest_client to rest_client. This avoids a conflict with the popular rest-client gem that uses the same RestClient class name.
@davesloan
Copy link
Copy Markdown
Owner

Thanks for doing this work! I'm concerned, however, that it's not backwards compatible. If someone updates the gem on their API project, this could potentially break a lot of things.

I think I'd rather have the option to set the name in the YML file and have a command line option in the generator so on installation, the name can be provided.

I welcome your thoughts on this.

@larryaasen
Copy link
Copy Markdown
Author

Thanks for looking at my code. You make a good point about backwards compatibility. This solution that I provided will break backwards compatibility. Let me look into your idea about setting the class name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants