Repository navigation
Graceful interrupt in the rendering pseudo-state - #2347
Merged
Merged
Conversation
Previously, mycli attempted to kill a remote thread on interrupt even in the "rendering" pseudo-state, at which point the remote thread is finished and nonexistent. That led to a cryptic failure error whenever Ctrl-C was pressed during the "rendering" state. This issue predates the background runner; at least, this particular cryptic error message does. Instead we should simply stop rendering on interrupt.
rolandwalker
force-pushed
the
RW/do-not-kill-nonexistent-remote-queries
branch
from
October 10, 2026 10:56
3e6a8be to
2bda459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, mycli attempted to kill a remote thread on interrupt even in the
renderingpseudo-state, at which point the remote thread is finished and nonexistent. That led to a cryptic failure error whenever Ctrl-C was pressed during therenderingstate.This issue predates the background runner; at least, this particular cryptic error message does.
Instead we should simply stop rendering on interrupt.
Checklist
changelog.mdfile.mycli/AUTHORS.txtfile (or it's already there).