Skip to content

this makes oracle materialised views and DDL parse correctly #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dr-kd wants to merge 6 commits into
base: master
Choose a base branch
from
Open

this makes oracle materialised views and DDL parse correctly #27

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
15a1b6e
this makes oracle materialised views and DDL amend correctly, includi…
Dec 24, 2021
4b2a96d
code review suggestion from robk
Dec 29, 2021
fa9b628
Warn if we are using too old a DBD::Oracle and will not be able to fi…
Dec 29, 2021
d9362df
squish warnings that can occur when ingesting a materialised view
Dec 29, 2021
f769ba5
do not add spurious virtual column constraints to materialised view r…
Dec 29, 2021
5766719
fix version number thinko
Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,12 +415,20 @@ sub _dbh_column_info {

sub _view_definition {
my ($self, $view) = @_;

return scalar $self->schema->storage->dbh->selectrow_array(<<'EOF', {}, $view->schema, $view->name);
my $viewdef = scalar $self->schema->storage->dbh
->selectrow_array(<<'EOF', {}, $view->schema, $view->name);
SELECT text
FROM all_views
WHERE owner = ? AND view_name = ?
EOF
return $viewdef if $viewdef;

my $mview = eval { scalar $self->schema->storage->dbh
->selectrow_array(<<'EOF', {}, $view->name, $view->schema);
select dbms_metadata.get_ddl('MATERIALIZED_VIEW', ?, ?) from dual
EOF
};
return $mview;
}

=head1 SEE ALSO
Expand Down