Fix logging setup in the CLI #1932
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p/fix_cli_logging__01
branch
from
56e1854 to
e02c98c
Compare
WilliamDee
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mfCLI was not loggingINFOmessages to the log file. This was traced to an imported module setting up the log configuration andlogging.basicConfigbecoming a no-op if handlers were already added to the root logger.This PR updates the CLI's logging setup method to use
logging.basicConfig(..., force=True)to address the no-op case and cleans up how the stream handler and the log file handler are set up.A test is added separately #1934 due to a required PR in the middle.