fix: cli for data export creation #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: v.oleynikov <[email protected]>
duckhawk
changed the title
ldmonster
approved these changes
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the default namespace value for data export and import CLI commands by centralizing it in a constant and correcting the value from "d8-data-exporter" to "d8-storage-volume-data-manager".
Changes:
- Adds a
Namespaceconstant tointernal/data/common.gowith the correct value "d8-storage-volume-data-manager" - Updates all data export and import commands to use the centralized constant instead of hardcoded namespace strings
- Adds necessary imports for the dataio package across affected files
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/data/common.go | Adds the Namespace constant with the correct namespace value |
| internal/data/cmd/data.go | Updates deprecated commands to use dataio.Namespace constant and adds import |
| internal/data/dataexport/cmd/create/create.go | Replaces hardcoded namespace with dataio.Namespace constant |
| internal/data/dataexport/cmd/delete/delete.go | Adds dataio import and uses Namespace constant |
| internal/data/dataexport/cmd/download/download.go | Replaces hardcoded namespace with dataio.Namespace constant |
| internal/data/dataexport/cmd/list/list.go | Replaces hardcoded namespace with dataio.Namespace constant |
| internal/data/dataimport/cmd/create/create.go | Adds dataio import and uses Namespace constant |
| internal/data/dataimport/cmd/upload/upload.go | Replaces hardcoded namespace with dataio.Namespace constant |
| internal/data/dataimport/cmd/upload/upload_windows.go | Replaces hardcoded namespace with dataio.Namespace constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in data export creation