-
Notifications
You must be signed in to change notification settings - Fork 0
[feature][bugfix] Multiple fixes and improvements #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IvanOgurchenok
wants to merge
48
commits into
main
Choose a base branch
from
multiple-fixes-and-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith environment variable validation for CLUSTER_CREATE_MODE. Update README with usage instructions and remove obsolete flag handling code.
…use the specified remote port directly. Adjust cluster creation tests to validate the local port is exactly 6445.
…template in images.go; refine cluster_config.yml comments
…r YAML filename and SSH parameters, improving readability and maintainability.
…, introducing new variables for namespace, storage class, and cleanup options. Update related validation logic and adjust cluster creation tests accordingly.
…adding checks in BeforeAll hooks. Update documentation comments for KubeConfigPath and TestClusterCreateMode to indicate test failure conditions if not set.
…tailed descriptions of test types, required environment variables, and instructions for running tests.
…es and finalize sections. Update cluster interface by commenting out unused VirtualizationClient. Correct typo in cluster_config.yml comments for worker nodes configuration.
… for connections through a jump host. Update error messages in environment validation to reflect correct variable names. Improve VM name extraction logic to comply with RFC 1123 rules and add new functions for obtaining setup node and VM IP address. Update cluster configuration in tests to reflect new OS types and improve cleanup logic in test suite.
…rap. Docker installation works.
…ated and deleted successfully
…U core allocation. Update related YAML parsing and VM creation logic to support this new field. Implement devBranch extraction from bootstrap config and add BootstrapCluster function for cluster initialization. Update test configurations to include coreFraction values and improve logging during cluster bootstrap process.
…ovide a link to the tests README
- Add TrustIfExists option for ClusterVirtualImages to reuse existing images - Add DataDiskSize option for VMs to create additional data disk - Add SKIP_VIRTUALIZATION_CHECK env to skip virtualization module check - Cache SSH passphrase after first input to avoid repeated prompts - Check all VMs in parallel during Step 5.1 instead of sequentially - Add documentation for new options in config files and README Signed-off-by: Ivan Ogurchenok <ivan.ogurchenok@flant.com>
- Store cloud-init config in Secret (bypass 2048 byte userData limit)
- Use user SSH key for VM connections, bootstrap key only for dhctl upload
- Add VerifyVMConfig to check/fix VM hostname after creation
- Add SecretClient for virtualization API
- Rename secret to e2e-cloudinit-{namespace}-{config} for clarity
- Update README with cloud-init secret documentation
Signed-off-by: Ivan Ogurchenok <ivan.ogurchenok@flant.com>
leave a comment about it. Signed-off-by: Ivan Ogurchenok <ivan.ogurchenok@flant.com>
- Add parallel worker bootstrapping with mutex-protected progress output - Add execWithWebhookRetry with configurable retry constants - Add kubectl aliases (k=kubectl) to cloud-init via /etc/profile.d/ - Update kernel versions in images.go to match actual cluster values Signed-off-by: Ivan Ogurchenok <ivan.ogurchenok@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major improvements to VM provisioning, cluster creation workflow, and module configuration.
✨ Features
VM Provisioning
⏳ VMs ready: 3/5dataDiskSizefor additional VirtualDiskk=kubectlwith completion via/etc/profile.d/SSH & Bootstrap
Worker Management
[N/M]Configuration
WebhookRetryAttempts=10🐛 Bug Fixes