Skip to content

Conversation

@LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented Jan 22, 2026

Description

  • Add a check for kvvmm.Status.StateChangeRequests before setting the AwaitingRestartToApplyConfiguration condition.
  • Skip volume migration when VM has RestartRequired status or pending RestartAwaitingChanges. This prevents patching KVVM volume spec while there are unapplied configuration changes waiting for a restart.

What is the expected result?

  • The VM controller now checks for kvvmm.Status.StateChangeRequests and skips setting the spurious AwaitingRestartToApplyConfiguration condition.
  • Volume migration is skipped when the VM is in RestartRequired state or has a pending RestartAwaitingChanges condition, ensuring the KVVM volume spec is not modified while unapplied configuration changes are still awaiting a restart.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: Prevent a false "Restart Required" condition when  restarting the VM.

@LopatinDmitr LopatinDmitr changed the title fix(vm): prevent false RestartRequired condition during os reboot fix(vm): prevent false RestartRequired condition during reboot into OS Jan 22, 2026
@LopatinDmitr LopatinDmitr changed the title fix(vm): prevent false RestartRequired condition during reboot into OS fix(vm): prevent false RestartRequired condition during reboot inside OS Jan 22, 2026
@LopatinDmitr LopatinDmitr added this to the v1.5.0 milestone Jan 22, 2026
@LopatinDmitr LopatinDmitr changed the title fix(vm): prevent false RestartRequired condition during reboot inside OS fix(vm): prevent False 'Restart Required' When OS Reboots Jan 22, 2026
@LopatinDmitr LopatinDmitr changed the title fix(vm): prevent False 'Restart Required' When OS Reboots fix(vm): prevent False 'Restart Required' when OS Reboots Jan 22, 2026
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-apply-new-spec-for-kvvm-when-os-reboot branch 4 times, most recently from a039374 to 2e0ff52 Compare January 26, 2026 16:51
@LopatinDmitr LopatinDmitr marked this pull request as ready for review January 26, 2026 16:54
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-apply-new-spec-for-kvvm-when-os-reboot branch 7 times, most recently from c609825 to 809c8f1 Compare January 27, 2026 12:52
@LopatinDmitr LopatinDmitr changed the title fix(vm): prevent False 'Restart Required' when OS Reboots fix(vm): prevent a false "Restart Required" condition when restarting the VM Jan 27, 2026
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-apply-new-spec-for-kvvm-when-os-reboot branch from 809c8f1 to d4c4434 Compare January 28, 2026 10:52
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-apply-new-spec-for-kvvm-when-os-reboot branch from d4c4434 to 9d0ad1f Compare January 28, 2026 10:54
@LopatinDmitr LopatinDmitr merged commit 7d012b5 into main Jan 28, 2026
27 of 28 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vm/fix-apply-new-spec-for-kvvm-when-os-reboot branch January 28, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants