-
Notifications
You must be signed in to change notification settings - Fork 5
fix(core): fix VMs with EFIWithSecureBoot bootloader failing to start when configured with more than 12 vCPUs
#1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
EFIWithSecureBoot bootloader failing to start when configured with more than 12 vCPUs
|
Workflow has started. The target step completed with status: failure. |
images/edk2/build.sh
Outdated
| # CC_FLAGS="${CC_FLAGS} -b DEBUG" # TEMP: enable debug to see OVMF errors in serial | ||
|
|
||
| CC_FLAGS="${CC_FLAGS} --cmd-len=65536" | ||
| CC_FLAGS="${CC_FLAGS} -D DEBUG_ON_SERIAL_PORT=TRUE" # TEMP: output debug to serial console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-D DEBUG_ON_SERIAL_PORT=TRUE — is it work without -b DEBUG?
Also, these 2 new settings are commented with "TEMP" — do we need them in main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it on purpose so that, if necessary, it could be quickly build with a debug build. But if such points are obvious, then you can remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not obvious what to change to build with debug output =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to enable debug build with -b DEBUG to enable output on serial port, or -D DEBUG_ON_SERIAL_PORT is enough and there is a runtime option for more verbose output for RELEASE build? Or we need rebuild ovmf to get verbose log on serial port? (I remember that ovmf rebuild may take ~40min).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put DEBUG instead of RELEASE )
Signed-off-by: Pavel Tishkov <[email protected]>
Description
Fix VMs with
EFIWithSecureBootbootloader failing to start when configured with more than 12 vCPUs.Why do we need it, and what problem does it solve?
VMs with SecureBoot were stuck in an infinite reboot loop or showing black screen when using more than ~12 cores.
What is the expected result?
VMs with
bootloader: EFIWithSecureBootboot successfully with any number of cores (up to 128).Checklist
Changelog entries