-
Notifications
You must be signed in to change notification settings - Fork 5
chore(vmop): refactoring vmop restore/clone #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eofff
wants to merge
12
commits into
main
Choose a base branch
from
chore/vmop/remove-restore-clone-complete-condition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
7bfa8e2 to
fac98f5
Compare
danilrwx
requested changes
Jan 27, 2026
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go
Show resolved
Hide resolved
.../virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/cleanup_snapshot_step.go
Show resolved
Hide resolved
.../virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/exit_maintenance_step.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/service/clone.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/service/clone.go
Outdated
Show resolved
Hide resolved
danilrwx
reviewed
Jan 27, 2026
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/service/clone.go
Outdated
Show resolved
Hide resolved
danilrwx
reviewed
Jan 27, 2026
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/service/clone.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
danilrwx
reviewed
Jan 28, 2026
...s/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/create_snapshot_step.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/final_step.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
danilrwx
previously approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring virtual machine restore and clone operation.
Checklist