Skip to content

Conversation

@RostyslavAntonyshyn
Copy link

No description provided.

@dajohi
Copy link
Member

dajohi commented Nov 1, 2018

@RostyslavAntonyshyn code needs to be run through gofmt

@jrick
Copy link
Member

jrick commented Nov 1, 2018

This code is also missing any sort of dependency version management which is a requirement. We're going to be converting the whole repo over to Go Modules so you can wait on that (instead of modifying the Gopkg.{toml,lock} which will be removed)

@dajohi
Copy link
Member

dajohi commented Feb 20, 2019

@RostyslavAntonyshyn please rebase now that go 1.11+ is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants