fix: add History message type support and prevent Content-Length header in WebSocket upgrade#396
Open
naomi-deepgram wants to merge 1 commit intomainfrom
Open
fix: add History message type support and prevent Content-Length header in WebSocket upgrade#396naomi-deepgram wants to merge 1 commit intomainfrom
naomi-deepgram wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"type": "History"server message that was not handled by the SDK — it would silently fall through to theUnhandledevent. This PR adds full support so subscribers can receive and act on History events.SocketsHttpHandlerviaHttpMessageInvoker, which does not add aContent-Length: 0header to the upgrade request. This header violates the WebSocket protocol and causes failures with strict proxies such as Azure API Management (APIM).Changes
History message type (
"type": "History")Deepgram/Models/Agent/v2/WebSocket/HistoryResponse.cs— New model withRole,Content, andFunctionCallsfields; includes aHistoryFunctionCallrecordDeepgram/Models/Agent/v2/WebSocket/AgentType.cs— AddedHistoryto theAgentTypeenum andHistory = "History"toAgentClientTypesDeepgram/Clients/Agent/v2/Websocket/Client.cs— Added_historyReceivedevent,Subscribe(EventHandler<HistoryResponse>), andcase AgentType.History:inProcessTextMessageDeepgram/Clients/Interfaces/v2/IAgentWebSocketClient.cs— AddedSubscribe(EventHandler<HistoryResponse>)to the interfaceContent-Length fix
Deepgram/Abstractions/v2/AbstractWebSocketClient.cs— OnNET5_0_OR_GREATER,ConnectAsyncis called with anHttpMessageInvokerwrappingSocketsHttpHandlerinstead of the default handler, preventingContent-Length: 0from being included in the WebSocket upgrade requestTest plan
AgentClientTests.cscoveringHistoryResponseserialisation,HistoryFunctionCallfield mapping, null-field omission, enum presence, and theAgentClientTypesconstant