chore: no-ticket: add spotless configuration to remove unused imports - #8305
chore: no-ticket: add spotless configuration to remove unused imports#8305devinrsmith wants to merge 5 commits into
Conversation
No docs changes detected for c83a550 |
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
| package io.deephaven.proto.backplane.grpc; | ||
|
|
||
| option java_multiple_files = true; | ||
| // to disambiguate from Java Object |
There was a problem hiding this comment.
Why did the spotless change make this come up now?
There was a problem hiding this comment.
I suspect the implementation of removeUnusedImports() does "simple" checks without actually compiling wrt the compile classpath, or has a hard-coded check that java.lang.Object never needs to be imported.
The protobuf codegen previously generated io.deephaven.proto.backplane.grpc.Object, meaning that java.lang.Object did need to be imported. This codegen class is "fluff" that we never actually need to reference (internal protobuf codegen may reference it), so I simply worked around this issue by changing the codegen class name to io.deephaven.proto.backplane.grpc.ObjectProto.
devinrsmith
left a comment
devinrsmith
left a comment
There was a problem hiding this comment.
Ryan asked about replication tasks:
replication-static:replicateAllSafe
does not produce clean results. This should not be merged until that is taken care of.
rcaudy
left a comment
rcaudy
left a comment
There was a problem hiding this comment.
Marking as "request changes" to block merge while replication is cleaned up.
No description provided.