ci: DH-23264: Rework test conventions - #8342
Open
stanbrub wants to merge 1 commit into
Open
Conversation
stanbrub
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for 85aa07b |
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks Gradle 9 test conventions and separates JMH benchmarks from test source sets.
Changes:
- Adds global defaults for custom
Testtasks. - Removes redundant task-level test wiring.
- Introduces dedicated benchmark source sets and classpaths.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
buildSrc/src/main/groovy/io.deephaven.java-test-conventions.gradle |
Adds custom Test task defaults. |
buildSrc/src/main/groovy/TestTools.groovy |
Removes obsolete manual wiring. |
engine/benchmark/build.gradle |
Migrates engine benchmarks to a dedicated source set. |
extensions/parquet/benchmark/build.gradle |
Migrates Parquet benchmarks. |
extensions/barrage/benchmark/build.gradle |
Migrates Barrage benchmarks. |
extensions/s3/build.gradle |
Removes redundant test task wiring. |
extensions/kafka/build.gradle |
Removes redundant test task wiring. |
extensions/iceberg/build.gradle |
Uses convention defaults for security-manager tests. |
extensions/iceberg/s3/build.gradle |
Uses convention defaults for container tests. |
web/client-api/client-api.gradle |
Uses convention defaults for GWT test tasks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
21
| configurations { | ||
| benchmarkImplementation.extendsFrom implementation | ||
| benchmarkRuntimeOnly.extendsFrom runtimeOnly | ||
| } |
Comment on lines
+18
to
21
| configurations { | ||
| benchmarkImplementation.extendsFrom implementation | ||
| benchmarkRuntimeOnly.extendsFrom runtimeOnly | ||
| } |
Comment on lines
+18
to
21
| configurations { | ||
| benchmarkImplementation.extendsFrom implementation | ||
| benchmarkRuntimeOnly.extendsFrom runtimeOnly | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Global convention for Gradle 9 Test task defaults (
io.deephaven.java-test-conventions.gradle):testClassesDirsandclasspathdefaults usingtesting.suites.test.sourcesin the existingconfigureEachblock. This restores the Gradle 8 behavior where custom Test tasks automatically inherited the test source set's configuration.Removed per-task boilerplate (5 files):
extensions/s3,extensions/kafka,extensions/iceberg/s3,extensions/iceberg,web/client-api— removed explicittestClassesDirs/classpaththat are now provided by the convention.Simplified TestTools.groovy:
setTestClassesDirs/setClasspathwiring (and unused imports) since the convention provides equivalent defaults.JMH benchmark projects refactored (3 files):
engine/benchmark,extensions/parquet/benchmark,extensions/barrage/benchmark— moved benchmark code from thetestsource set to a dedicatedbenchmarksource set. This eliminates the need forfailOnNoDiscoveredTests = falseand properly separates benchmark infrastructure from test infrastructure.