fix: DH-23165: Fix spectrum Picker closing Popper dialogs on open - #2726
Open
vbabich wants to merge 6 commits into
Open
fix: DH-23165: Fix spectrum Picker closing Popper dialogs on open#2726vbabich wants to merge 6 commits into
vbabich wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in portal containment to Popper, preventing nested Spectrum overlays from dismissing their parent dialog.
Changes:
- Introduces
containPortalsusing React Aria’s portal provider. - Adds stacking-context isolation for contained overlays.
- Adds styleguide, unit, and E2E regression coverage.
Reviewed changes
Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/components/src/popper/Popper.tsx |
Implements portal containment. |
packages/components/src/popper/Popper.scss |
Isolates contained overlay stacking. |
packages/components/src/popper/Popper.test.tsx |
Tests opt-in and default rendering. |
packages/components/package.json |
Adds the React Aria dependency. |
packages/code-studio/src/styleguide/Dialog.tsx |
Adds a nested Picker example. |
tests/styleguide.spec.ts |
Adds the E2E visual regression test. |
package-lock.json |
Records the dependency update. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
+ Coverage 51.40% 51.51% +0.10%
==========================================
Files 797 797
Lines 45852 45859 +7
Branches 11906 11720 -186
==========================================
+ Hits 23569 23622 +53
+ Misses 22264 22218 -46
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vbabich
enabled auto-merge (squash)
July 23, 2026 20:05
mofojed
requested changes
Jul 24, 2026
mofojed
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
containPortalsprop to the Popper dialog to allow nested spectrum Pickers and not dismiss the dialog on Picker open.Verified manually on the http://localhost:4220/ide/styleguide#popover-dialog page and the PivotBuilder plugin aggregations config section (will post a separate PR in the deephaven-plugins repo).
Added unit and e2e tests.