Use alias chain to avoid overwriting previous attribute method declarations#3
Open
nickewing wants to merge 7 commits into
Open
Use alias chain to avoid overwriting previous attribute method declarations#3nickewing wants to merge 7 commits into
nickewing wants to merge 7 commits into
Conversation
…ite previous functionality
Owner
|
I don't maintain or use this library anymore. Maybe you want to take it over? |
Author
|
Yes, we can take it over. Could we transfer that to the AnalogAnalytics (analog-analytics) organization? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation defines accessor methods for the attributes it's declared for. When used with other plugins (such as globalize2), the accessor methods overwrite the functionality of the previously declared method. This patch uses alias method chaining to correct the problem.
Example of problem: