Add dropdown menu, advanced list content and message components#8
Open
tdanecker wants to merge 9 commits intodeg:masterfrom
Open
Add dropdown menu, advanced list content and message components#8tdanecker wants to merge 9 commits intodeg:masterfrom
tdanecker wants to merge 9 commits intodeg:masterfrom
Conversation
tdanecker
force-pushed
the
feature/additions
branch
from
e410a6f to
9c84b69
Compare
tdanecker
force-pushed
the
feature/additions
branch
from
9c84b69 to
ae661ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some more components from semantic-ui:
The style how parentheses were used in the keys.clj file was very inconsistent. I changed them to a parinfer style in a separate commit so that it's easier to work with this file.
Also, I fixed a typo in the dropdown keys.
Just let me know if I should create separate PRs for those changes.
Also, I'm not that happy about dropdown-menus for now. It has to be called as a function instead of a component. Otherwise the dropdown-menu wouldn't open when clicked. I suspect that the Dropdown expects the Dropdown.Menu as a direct ancestor but sodium would introduce a small wrapper-component in between which messes things up.
[na/dropdown {} (na/dropdown-menu {} [na/dropdown-item {:text "menu item"}])]