Conversation
| /// Updates the MPNowPlayingInfoCenter with current item's info. | ||
| func updateNowPlayingInfoCenter() { | ||
| #if os(iOS) || os(tvOS) | ||
| #if !os(macOS) |
There was a problem hiding this comment.
There is no way to s.osx.exclude_files = 'AudioPlayer/AudioPlayer/utils/MPNowPlayingInfoCenter+AudioItem.swift' on SPM.
There was a problem hiding this comment.
We could change it back to #if os(iOS) || os(tvOS) but I would need to replicate it on https://github.com/delannoyk/AudioPlayer/blob/abc43937c129e023eacddcea8ba1367292c2aee5/AudioPlayer/AudioPlayer/utils/MPNowPlayingInfoCenter%2BAudioItem.swift too.
There was a problem hiding this comment.
Apologies for the delay! If you don't mind, I'd appreciate this change 😄
There was a problem hiding this comment.
@delannoyk ? Is there any concise reason for that?
There was a problem hiding this comment.
It feels more correct to me to include the platform we know are supported, rather than exclude the ones we know aren't. I.E: what about watchOS, visionOS? I actually haven't tested those platforms but I would want to before saying they're supported for that code path. Does that make sense?
There was a problem hiding this comment.
This seems right. Thank you for the response. I will update it when I have time.
ppamorim
force-pushed
the
feature/swiftpm
branch
2 times, most recently
from
7094fa6 to
4498d6f
Compare
ppamorim
force-pushed
the
feature/swiftpm
branch
from
4498d6f to
abc4393
Compare
2 participants
I will keep this PR as draft until #190 gets merged. I am using this branch by myself so I can't rebase it yet.