perf: fast wasm streaming #31203
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. | ||
|
|
||
| use std::cell::RefCell; | ||
| use std::rc::Rc; | ||
|
|
||
| use deno_core::OpState; | ||
| use deno_core::ResourceId; | ||
| use deno_core::v8; | ||
| use deno_error::JsErrorBox; | ||
|
|
||
| /// The Wasm streaming compilation pipeline. | ||
| pub fn handle_wasm_streaming<'a>( | ||
| state: Rc<RefCell<OpState>>, | ||
| scope: &mut v8::PinScope<'a, '_>, | ||
| value: v8::Local<'a, v8::Value>, | ||
| mut wasm_streaming: v8::WasmStreaming, | ||
| ) { | ||
| let (url, rid) = match compile_response(scope, value) { | ||
| Ok(Some((url, rid))) => (url, rid), | ||
| Ok(None) => { | ||
| // 2.7 | ||
| wasm_streaming.finish(); | ||
| return; | ||
| } | ||
| Err(e) => { | ||
| // 2.8 | ||
| let err = v8::String::new(scope, &e.to_string()).unwrap(); | ||
| wasm_streaming.abort(Some(err.into())); | ||
| return; | ||
| } | ||
| }; | ||
|
|
||
| wasm_streaming.set_url(&url); | ||
|
|
||
| deno_core::unsync::spawn(async move { | ||
| loop { | ||
| let resource = state.borrow().resource_table.get_any(rid); | ||
| let resource = match resource { | ||
| Ok(r) => r, | ||
| Err(_) => { | ||
| state.borrow().borrow::<deno_core::V8TaskSpawner>().spawn( | ||
| move |scope| { | ||
| wasm_streaming.abort(Some( | ||
| v8::String::new(scope, "Failed to get resource.") | ||
| .unwrap() | ||
| .into(), | ||
| )) | ||
| }, | ||
| ); | ||
| return; | ||
| } | ||
| }; | ||
|
|
||
| let view = deno_core::BufMutView::new(65536); | ||
| let (bytes, view) = match resource.read_byob(view).await { | ||
| Ok(bytes) => bytes, | ||
| Err(e) => { | ||
| state.borrow().borrow::<deno_core::V8TaskSpawner>().spawn( | ||
| move |scope| { | ||
| wasm_streaming.abort(Some( | ||
| v8::String::new( | ||
| scope, | ||
| &format!("Error reading wasm resource: {}", e), | ||
| ) | ||
| .unwrap() | ||
| .into(), | ||
| )) | ||
| }, | ||
| ); | ||
|
|
||
| return; | ||
| } | ||
| }; | ||
| /* EOF */ | ||
| if bytes == 0 { | ||
| break; | ||
| } | ||
|
|
||
| wasm_streaming.on_bytes_received(&view[..bytes]); | ||
| } | ||
|
|
||
| /* Spawn a task on JS loop to finish the streaming compilation */ | ||
| state | ||
| .borrow() | ||
| .borrow::<deno_core::V8TaskSpawner>() | ||
| .spawn(move |_| wasm_streaming.finish()); | ||
| }); | ||
| } | ||
|
|
||
| // Partially implements https://webassembly.github.io/spec/web-api/#compile-a-potential-webassembly-response | ||
| pub fn compile_response<'a>( | ||
| scope: &mut v8::PinScope<'a, '_>, | ||
| value: v8::Local<'a, v8::Value>, | ||
| ) -> Result<Option<(String, ResourceId)>, JsErrorBox> { | ||
| let object = value | ||
| .to_object(scope) | ||
| .ok_or_else(|| JsErrorBox::type_error("Response is not an object."))?; | ||
| let url = get_string(scope, object, "url")?; | ||
|
|
||
| // 2.3. | ||
| // The spec is ambiguous here, see | ||
| // https://github.com/WebAssembly/spec/issues/1138. The WPT tests expect | ||
| // the raw value of the Content-Type attribute lowercased. We ignore this | ||
| // for file:// because file fetches don't have a Content-Type. | ||
| if !url.starts_with("file://") { | ||
| let headers = get_value(scope, object, "headers")?; | ||
| let content_type = call_method(scope, headers, "get", "Content-Type")?; | ||
|
|
||
| if content_type.to_lowercase() != "application/wasm" { | ||
| return Err(JsErrorBox::type_error("Response is not a wasm file.")); | ||
| } | ||
| } | ||
|
|
||
| // 2.5 | ||
| let ok = get_value(scope, object, "ok")?; | ||
| if !ok.is_true() { | ||
| return Err(JsErrorBox::type_error("Response is not ok.")); | ||
| } | ||
|
|
||
| let body = get_value(scope, object, "body")?; | ||
|
|
||
| if body.is_null() { | ||
| return Ok(None); | ||
| } | ||
| let body = body | ||
| .to_object(scope) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to get body object."))?; | ||
| let rid = get_value(scope, body, "rid")? | ||
| .to_uint32(scope) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to get rid."))? | ||
| .value() as ResourceId; | ||
|
|
||
| Ok(Some((url, rid))) | ||
| } | ||
|
|
||
| fn get_value<'a, 'b>( | ||
| scope: &'b mut v8::PinScope<'a, '_>, | ||
| obj: v8::Local<'a, v8::Object>, | ||
| key: &'static str, | ||
| ) -> Result<v8::Local<'a, v8::Value>, JsErrorBox> { | ||
| let key = v8::String::new(scope, key) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to create key."))?; | ||
| Ok( | ||
| obj | ||
| .get(scope, key.into()) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to get value."))?, | ||
| ) | ||
| } | ||
|
|
||
| fn get_string( | ||
| scope: &mut v8::PinScope, | ||
| obj: v8::Local<v8::Object>, | ||
| key: &'static str, | ||
| ) -> Result<String, JsErrorBox> { | ||
| let key = v8::String::new(scope, key) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to create key."))?; | ||
| let value = obj | ||
| .get(scope, key.into()) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to get value."))?; | ||
|
|
||
| Ok(value.to_rust_string_lossy(scope)) | ||
| } | ||
|
|
||
| fn call_method<'a>( | ||
| scope: &mut v8::PinScope<'a, '_>, | ||
| obj: v8::Local<'a, v8::Value>, | ||
| method: &'static str, | ||
| arg: &'static str, | ||
| ) -> Result<String, JsErrorBox> { | ||
| let key = v8::String::new(scope, method) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to create key."))?; | ||
| let function = obj | ||
| .to_object(scope) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to create object."))?; | ||
| let function = function | ||
| .get(scope, key.into()) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to get value."))?; | ||
| let function: v8::Local<v8::Function> = function | ||
| .try_into() | ||
| .map_err(|_| JsErrorBox::type_error("Failed to get function."))?; | ||
| let arg = v8::String::new(scope, arg) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to create arg."))?; | ||
| Ok( | ||
| function | ||
| .call(scope, obj, &[arg.into()]) | ||
| .ok_or_else(|| JsErrorBox::type_error("Failed to call."))? | ||
| .to_rust_string_lossy(scope), | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this already exists under
Symbol(_resourceBacking)