Skip to content

feat: accept target-suffixed RUSTY_V8_ARCHIVE #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: accept target-suffixed RUSTY_V8_ARCHIVE #1816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ fn main() {
// probably more than what is needed, but missing an important
// variable can lead to broken links when switching rusty_v8
// versions.
let target = env::var("TARGET").unwrap().replace("-", "_");
let rusty_v8_archive_target = format!("RUSTY_V8_ARCHIVE_{target}");
let envs = vec![
"CCACHE",
"CLANG_BASE_PATH",
Expand All @@ -39,6 +41,7 @@ fn main() {
"NINJA",
"OUT_DIR",
"RUSTY_V8_ARCHIVE",
rusty_v8_archive_target.as_str(),
"RUSTY_V8_MIRROR",
"RUSTY_V8_SRC_BINDING_PATH",
"SCCACHE",
Expand Down Expand Up @@ -435,6 +438,11 @@ fn static_lib_name(suffix: &str) -> String {
}

fn static_lib_url() -> String {
let target = env::var("TARGET").unwrap();
let rusty_v8_archive_target = format!("RUSTY_V8_ARCHIVE_{target}");
if let Ok(custom_archive) = env::var(rusty_v8_archive_target) {
return custom_archive;
}
if let Ok(custom_archive) = env::var("RUSTY_V8_ARCHIVE") {
return custom_archive;
}
Expand Down
Loading