Skip to content

Conversation

@timreichen
Copy link
Contributor

Dependent on #6904

This PR refactors composeNode() by using early returns. Some lines code are repeated in order to do that, which can be abstracted further in future PRs.

@github-actions github-actions bot added the yaml label Dec 20, 2025
@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 77.35849% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (c9ba826) to head (c7083e7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
yaml/_loader_state.ts 77.35% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6905      +/-   ##
==========================================
- Coverage   94.16%   94.14%   -0.03%     
==========================================
  Files         583      583              
  Lines       42811    42825      +14     
  Branches     6815     6821       +6     
==========================================
+ Hits        40314    40316       +2     
- Misses       2446     2457      +11     
- Partials       51       52       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen marked this pull request as ready for review December 25, 2025 11:24
@timreichen timreichen requested a review from kt3k as a code owner December 25, 2025 11:24
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks easier to understand now. Thanks!

@kt3k kt3k merged commit 13e5527 into denoland:main Dec 26, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants