Support the LSP built into Typescript 7 (typescript-go) - #5160
Open
Jiggins wants to merge 1 commit into
Open
Conversation
Jiggins
force-pushed
the
linter/typescript-go-lsp
branch
from
August 6, 2026 17:06
6e9b776 to
4dea43c
Compare
Typescript moved to go for the 7.0 release. They also ditched `tsserver` in favour of `tsc --lsp`. This commit implements an ALE LSP definition for `tsc --lsp`. From testing, `tsc --lsp` doesn't seem to be as good as the old `tsserver` but hopefully it'll get better. Completion is not as good as before but the documentation (:ALEHover) seems to be a little better. Fixes: dense-analysis#5128
Jiggins
force-pushed
the
linter/typescript-go-lsp
branch
from
August 10, 2026 09:39
4dea43c to
73330dc
Compare
hsanson
requested changes
Aug 19, 2026
hsanson
left a comment
hsanson
left a comment
Contributor
There was a problem hiding this comment.
Before merging this needs to include tests and documentation updates. See this PR as reference:
In specific:
- New test
test/linter/test_typescript_tsc.vader - Entry in supported-tools.md
- Entry in txt/ale.txt
- Entry in doc/ale-supported-languages-and-tools.txt
- Help entry in doc/ale-typescript.txt
Important: entries in documentation must be added in alphabetical order to avoid linter errors.
|
Note that this does not really work for It works, but I have know knowledge on ALE aliasing or how LSP work so perhaps this is not the best solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript moved to go for the 7.0 release. They also ditched
tsserverin favour of
tsc --lsp. This commit implements an ALE LSP definitionfor
tsc --lsp.From testing,
tsc --lspdoesn't seem to be as good as the oldtsserverbut hopefully it'll get better.Fixes: #5128