Skip to content

Conversation

@SebastianStehle
Copy link

No description provided.

@derekeder
Copy link
Owner

Thanks for this contribution @SebastianStehle!

Could you give a little more description for these changes? Do you know when it wouldn't be possible to get the tableId and geometryColumn from the FusionTablesLayer?

Also, what's the purpose of the hasMapTips function?

var containerPos = findElPos(me.getMap().getDiv());
var tol = opts.tolerance || 6;


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove these extra line breaks

@SebastianStehle
Copy link
Author

I dont think that there is any case where you dont want to use the parameters from the layer. You want to have the tooltips for the data you display, so it should be the same parameters, isnt it? ;) It is always a good idea to follow the DRY principle.

I have a scenario where I use multiple layers and turn them on and off after user interactions. Therefore it was really helpful to have a method hasMapTips and also to make the disableMapTips a little bit more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants