Skip to content

Gpgcheck switch #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Gpgcheck switch #203

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c008653
updated readme
Mar 16, 2018
30ab250
added default empty array for [os-hardening]['yum']['gpg_exclude']
Mar 16, 2018
6a619ea
updated repos.d file
Mar 16, 2018
fd6873c
update
Mar 16, 2018
926643e
minor update
Mar 16, 2018
d7bee84
Amzlinux2 (#3)
May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ It will not:
* Sander van Zoest sysctl `https://github.com/svanzoest-cookbooks/sysctl`

## Attributes

* `['os-hardening']['yum']['gpg_exclude'] = []` - Array of yum configuration files to exclude from gpgcheck
* `['os-hardening']['components'][COMPONENT_NAME]` - allows the fine control over which components should be executed via default recipe. See below for more details
* `['os-hardening']['desktop']['enable'] = false`
true if this is a desktop system, ie Xorg, KDE/GNOME/Unity/etc
Expand Down
1 change: 1 addition & 0 deletions attributes/default.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
default['os-hardening']['packages']['pam_cracklib'] = 'pam_cracklib'
default['os-hardening']['packages']['pam_pwquality'] = 'libpwquality'
default['os-hardening']['packages']['auditd'] = 'audit'
default['os-hardening']['yum']['gpg_exclude'] = []

if node['platform_version'].to_f < 7
default['os-hardening']['auth']['pam']['passwdqc']['enable'] = true
Expand Down
16 changes: 13 additions & 3 deletions recipes/yum.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,25 @@
block do
# TODO: harmonize with latter function
config_file = '/etc/yum.conf'
GPGCheck.check(config_file)
# Only check files not listed in gpg_exclude array
unless node['os-hardening']['yum']['gpg_exclude'].include? config_file
GPGCheck.check(config_file)
end

Dir.glob('/etc/yum.repos.d/*').each do |file|
GPGCheck.check(file)
config_file = '/etc/yum.conf'
Copy link
Member

@chris-rock chris-rock May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the config_file line here?

# Only check files not listed in gpg_exclude array
unless node['os-hardening']['yum']['gpg_exclude'].include? file
GPGCheck.check(file)
end
end

rhn_conf = '/etc/yum/pluginconf.d/rhnplugin.conf'
File.file?(rhn_conf) do
GPGCheck.check(rhn_conf)
# Only check files not listed in gpg_exclude array
unless node['os-hardening']['yum']['gpg_exclude'].include? rhn_conf
GPGCheck.check(rhn_conf)
end
end
end
action :run
Expand Down