Open
Conversation
1. Modify pulsar.py to add orbital degradation factor as an attribute to each pulsar object (orb_degfac). 2. Modify survey.py to record the snr for each pulsar object in its pulsar.snr attribute.
… done implicitly in Py3.xx
…ce Py3.xx does not do this implicitly
m1 -> mass of psr m2 -> mass of companion om -> angle of periastron passage (omper) inc -> inclination of BNS system ec -> eccentricity of BNS pod -> orbital period of BNS m -> harmonic at which power is computed Consequently, added functionality for Population object to hold the ranges of the BNS orbital parameters. populate.generate() now draws uniformly from the range of orbital parameters supplied by the user (as a dictionary).
cannot compare float to NoneType in Python3. changed gpsargs to [-1, -1] from [-1, None] so that condition evaluates to true for default case.
cannot compare floats to NoneType in py3. change gpsfrac to -1 so that default behavior is satisfied.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures psrpoppy2 is able to work with Python 3.x.
This pull request also introduces capability to associate orbital parameters with a Pulsar object, though functionality to use them to calculate the orbital degradation factor still remains to be implemented (ongoing work).