compiler: Enable blocking-before-CIRE#2948
Conversation
| else: | ||
| self.umt_reduce = UnboundTuple(*par_tile.default, 1) | ||
|
|
||
| def next(self, prefix, d, clusters): |
There was a problem hiding this comment.
significant reduction in complexity
| assert iters[0].step == par_tile[1] | ||
| assert iters[1].step == par_tile[0] | ||
|
|
||
| def test_custom_rule0(self): |
There was a problem hiding this comment.
unused feature, dropped; so dropping the tests too
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2948 +/- ##
==========================================
+ Coverage 82.86% 83.45% +0.58%
==========================================
Files 249 249
Lines 52268 52427 +159
Branches 4499 4509 +10
==========================================
+ Hits 43314 43753 +439
+ Misses 8184 7913 -271
+ Partials 770 761 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| """Return the DataSpace of this ClusterGroup.""" | ||
| return DataSpace.union(*[i.dspace.reset() for i in self]) | ||
|
|
||
| @property |
|
|
||
| # Overrides the default values in the main Operator class | ||
| BLOCK_LEVELS = 0 | ||
| CIRE_BLOCK_TEMPS = False |
There was a problem hiding this comment.
Is it intended to be a default or enforced?
There was a problem hiding this comment.
enforced or things would break
| if not mapper: | ||
| return self | ||
|
|
||
| if self.halo_scheme: |
There was a problem hiding this comment.
Can probably be relaxed to self.halo_scheme.distributed_aindices & mapper.keys()
| # Handle ComponentAccesses | ||
| subs = {i: Symbol(f'dummy{n}') for n, i in enumerate(compaccs)} | ||
| exprs1 = uxreplace(exprs, subs) | ||
| terms1 = retrieve_terminals(exprs1, **kwargs) |
There was a problem hiding this comment.
would likely be "cheaper" to have an ignore=compaccs in retrieve_terminals
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
FabioLuporini
force-pushed
the
smarter-tuner-3
branch
from
08dee85 to
65ad8a1
Compare
FabioLuporini
force-pushed
the
smarter-tuner-3
branch
from
65ad8a1 to
1b6dae5
Compare
FabioLuporini
force-pushed
the
smarter-tuner-3
branch
from
5490ce6 to
757726c
Compare
2 participants
This is key for features in PRO
In doing so, several utility functions are added, which might come in handy in the future as well
Some clean up also, which is never a bad thing