1719: Rust Integration#1913
Conversation
Coverage Report for CI Build 26581888672Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.03%) to 71.082%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions33 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
447da62 to
18fc327
Compare
dcc6a84 to
f150bd6
Compare
|
@hohwille |
fa59dfd to
c7ce5cb
Compare
ef18639 to
b6b4324
Compare
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
7e990d3 to
ba5d98f
Compare
AdemZarrouki
left a comment
There was a problem hiding this comment.
I think the Licence are still missing in the PR.
AdemZarrouki
left a comment
There was a problem hiding this comment.
Tested on windows and rust was successfully
$ ide rust
Usage: rustc [OPTIONS] INPUT
| } | ||
|
|
||
| @Override | ||
| protected void installDownloadedToolPayload(ToolInstallRequest request, Path installationPath, Path installerScript) { |
There was a problem hiding this comment.
Regarding installDownloadedToolPayload, I'm not exactly sure what to name this new hook, given that there are already a lot of methods in this file containing the word install in it.
This PR Fixes #1719
Continuation of PR #1827
ide install rust1.1.0) instead of always resolving to the defaultrelease-0.7.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)internalChecklist for tool commandletsHave you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet