#1953: Implement base functionality of Cleanup Commandlet#1957
#1953: Implement base functionality of Cleanup Commandlet#1957areinicke wants to merge 16 commits into
Conversation
Coverage Report for CI Build 26210991945Warning No base build found for commit Coverage: 70.967%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
Caylipp
left a comment
There was a problem hiding this comment.
I tested the cleanup commandlet locally.
For my manual test, I installed additional versions of gh and java and then ran ide cleanup. Only the extra unused versions were deleted, while the versions still referenced by a project were kept. So the basic deletion functionality worked for me.
I noticed an issue in ide shell where duplicate entries appeared on a second run. However, this issue has already been fixed.
Overall, the implementation looks good to me and my manual test worked. Very good!
This PR fixes #1953
Implemented changes:
cleanupcommandlet. Users can runide cleanupto scan for unused tool installations and automatically remove them. A tool is considered as unused if no project links to the tool installation from its software folder at$IDE_ROOT/<project>/softwareor$IDE_ROOT/<project>/software/extra.--fd.ide helpdocumentation for the new commandletTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
set-editionandset-versioncommandlet repeatedly.AND
ide helpandide help cleanupto verify that the help documentation works as expected.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal