Skip to content

#1947 create gc log analyzer url updater#1977

Merged
hohwille merged 7 commits into
devonfw:mainfrom
Caylipp:feature/1947-Create-GcLogAnalyzerUrlUpdater
May 29, 2026
Merged

#1947 create gc log analyzer url updater#1977
hohwille merged 7 commits into
devonfw:mainfrom
Caylipp:feature/1947-Create-GcLogAnalyzerUrlUpdater

Conversation

@Caylipp
Copy link
Copy Markdown
Contributor

@Caylipp Caylipp commented May 26, 2026

This PR fixes #1947

Implemented changes:

  • Added a new GcLogAnalyzerUrlUpdater for the GC Log Analyzer tool.
  • Registered the new updater in the UpdateManager.
  • Changed version detection to read versions from the Azul GC Log Analyzer release notes page.
  • Added support for versions with an optional fourth version segment, e.g. 24.10.0.0.
  • Added handling for older versions where the release notes version is 24.10.0.0, but the CDN download URL uses 24.10.0.
  • Added a WireMock-based test and mock updater for the GC Log Analyzer URL updater.
  • Verified that multiple versions are detected and that the special 24.10.0.0 download URL case is handled correctly.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run the GC Log Analyzer updater test:

    mvn -pl url-updater -Dtest=GcLogAnalyzerUrlUpdaterTest test
    

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

Caylipp added 3 commits May 21, 2026 16:56
- added GC Log Analyzer URL updater
- register updater in UpdateManager
-Update the version pattern to read multiple GC Log Analyzer versions from the release notes page.
-Add a WireMock-based mock and test for the updater.
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 26, 2026

Coverage Report for CI Build 26654297571

Coverage increased (+0.03%) to 71.101%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15728
Covered Lines: 11664
Line Coverage: 74.16%
Relevant Branches: 7006
Covered Branches: 4500
Branch Coverage: 64.23%
Branches in Coverage %: Yes
Coverage Strength: 3.13 hits per line

💛 - Coveralls

@Caylipp Caylipp added enhancement New feature or request urls ide-urls repo and related processes and features labels May 26, 2026
@tineff96 tineff96 self-assigned this May 26, 2026
@tineff96 tineff96 moved this from 🆕 New to Team Review in IDEasy board May 26, 2026
Copy link
Copy Markdown
Contributor

@tineff96 tineff96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the branch locally and ran the new updater test successfully:

mvn -pl url-updater -Dtest=GcLogAnalyzerUrlUpdaterTest test

Result: Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

The implementation looks good to me.

@Caylipp Caylipp moved this from Team Review to 👀 In review in IDEasy board May 29, 2026
@Caylipp Caylipp moved this from 👀 In review to Team Review in IDEasy board May 29, 2026
@hohwille hohwille moved this from Team Review to 👀 In review in IDEasy board May 29, 2026
@hohwille hohwille added this to the release:2026.06.001 milestone May 29, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Caylipp thanks for your PR. Surely using WebsiteUrlUpdater has a tendency to be fragile but we already discussed that we do not see other options here.
Your PR looks good to me and is ready to merge. Great job 👍

@hohwille hohwille merged commit dc1835d into devonfw:main May 29, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request urls ide-urls repo and related processes and features

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create GcLogAnalyzerUrlUpdater

4 participants