#1968: Launch GUI in background#1984
Merged
hohwille merged 6 commits intoMay 29, 2026
Merged
Conversation
…es not block the terminal
Collaborator
Coverage Report for CI Build 26650357092Coverage increased (+0.009%) to 71.097%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
AdemZarrouki
approved these changes
May 29, 2026
Contributor
Author
|
Made a little mistake while resolving a merge conflict... will clean this up quickly and then mark it as ready to merge again |
hohwille
approved these changes
May 29, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@laim2003 thanks for this PR. Besides running in background you also fixed a bug that you already fixed in PR #1967 and I did not understand it during the review and since time was running out before the release I just reverted your change causing the bug again.
Sorry for that and great that you fixed it again. 👍
Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1968
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal