fix(distribution): preserve off policy in provider manifest

[skevetter]

Devsy's YAML parser interprets the unquoted off enum as a boolean, so the published provider rejects MICROSANDBOX_WORKSPACE_STAT_VIRTUALIZATION=off before starting a VM. This quotes the literal policy in the generated manifest and extends the existing installer smoke to require all three policies after parsing with the pinned real Devsy host.

The new parser assertion failed on the previous manifest (strict,relaxed,) and passes with the corrected manifest (strict,relaxed,off). Local race tests, vet, strict lint/format and all prek hooks passed; the actual host download/checksum/version smoke also passed. Local artifact fixtures copy the native host executable into four filenames solely to exercise metadata generation; the CI distribution matrix must still build and validate all four native platforms.

This is the narrow prerequisite for the two failing off-policy cases in devsy-org/devsy#1453. The mount tests and runtime policy remain unchanged. Full committed local CodeRabbit reviewed both changed files with zero findings; implementation CI and final-head Greptile/CodeRabbit gates must pass before merge.

Summary by CodeRabbit

• Bug Fixes
  • Provider installation now checks that the workspace stat virtualization setting is present and offers the supported choices: strict, relaxed, and off. Missing or unexpected choices now produce an error.
  • Corrected the presentation of the off choice in the provider configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 326ad292-03ab-46fa-9fa3-ba5431596252

---

---

📥 Commits

Reviewing files that changed from the base of the PR and between 2a5f248 and 358d512.

---

---

📒 Files selected for processing (2)

• integration/provider_install.go
• internal/distribution/provider.yaml.tmpl

---

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

---

📝 Walkthrough

📝 Walkthrough

Walkthrough

The provider template quotes the off enum value for MICROSANDBOX_WORKSPACE_STAT_VIRTUALIZATION. The installation check rejects configurations that omit this option or whose enum values do not match strict,relaxed,off in order.

Changes

Workspace stat virtualization option

Layer / File(s)	Summary
Option contract and installation validation internal/distribution/provider.yaml.tmpl, integration/provider_install.go	The template quotes the off enum value. The installation check requires the option and the ordered enum values strict,relaxed,off.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

---

---

Merge Risk: ⚪ Minimal · up to 358d5

The generated manifest preserves off as a string, and installation verifies the ordered option values. No actionable merge risk is evident in these changes; proceed with the project's normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 358d5

The change affects 2 systems.

Changed systems: integration, internal

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — integration (service) was modified; 1 changed file maps to changed impact.
• observed — internal (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in integration/provider_install.go: run now rejects configurations missing the workspace stat virtualization option and rejects its enum unless the ordered values are exactly strict,relaxed,off.
• observed — Modified behavior in internal/distribution/provider.yaml.tmpl: The off enum value is now quoted as "off".

---

---

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: preserving the literal off policy in the generated provider manifest.

---

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

---

• Fix all pre-merge checks with AI

✨ Finishing Touches

✨ Simplify code

• Commit to this branch
• Create a new PR

---

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[skevetter]

@greptileai review

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Preserves off as a string in the published provider manifest.

• Devsy keeps the off workspace policy as a text choice.

_{Reviews (1) · Last reviewed commit: "fix(distribution): preserve off policy i..." · Reviewed by Greptile}

[skevetter]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[skevetter]

Final-head review disposition for 358d512cb76f74de88eb7f6be60ca5fc58b1d4a9: local full review and completed remote full CodeRabbit run 326ad292-03ab-46fa-9fa3-ba5431596252 covered both changed files without actionable findings; Greptile reported 5/5. All implementation checks passed, including four native packages and the real pinned Devsy installer smoke.

The CodeRabbit linter subtool warning is explained by the intentional //go:build ignore boundary on integration/provider_install.go. The helper imports host-only Devsy packages and is explicitly compiled/run from the pinned Devsy module by distribution CI; adding it to this provider module would break that boundary. That actual compile/run passed. The private command helper's unsupported docstring-coverage warning does not identify a behavior defect or a required repository check. No code change is warranted for either warning. Full merge-risk and architecture sections report no concerns, and no actionable threads remain.