You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MicroSandbox parity checks do not yet verify persistent root-disk capacity or its data lifecycle. Add the same three scenarios for the built-in driver and published external provider v0.1.6: the runtime default, explicit provider storage overriding host requirements, and fractional host storage rounded up when the provider value is zero.
Each scenario checks active root-disk configuration and actual guest filesystem capacity, then proves that a VM-local file survives stop/start and disappears after recreation while host workspace content persists. Creation time and boot IDs distinguish resume from replacement. A dedicated KVM CI entry uses the existing checksum-pinned MicroSandbox v0.7.7 setup, alongside all earlier parity suites.
Validation:
Focused uncached race tests passed; vet and module verification passed.
Ginkgo dry run selected six scenarios. The dry run only validates selection; the actual CI run has now passed all six storage VM scenarios against the built-in driver and published external provider v0.1.6.
Strict lint passed with zero issues, all 13 repository hooks passed, and fresh full committed local CodeRabbit reviewed all three changed files with zero findings.
All 76 implementation CI jobs passed on 104e439, including the existing lifecycle, image, mount and resource suites plus the new storage suite (36 selected scenarios total). Fresh remote reviews are pending.
Ephemeral roots, network policy, prebuilds, Dockerless behavior, logs, cancellation and compatibility remain separate parity work. This PR does not change the default provider implementation.
Summary by CodeRabbit
Tests
Added end-to-end checks for persistent storage capacity across built-in and external providers, including default, configured, and host-requirement-based sizing.
Verified that guest data persists after a stop and restart, while recreating a sandbox resets guest data.
Documentation
Updated provider parity guidance to include persistent-storage checks and their expected behavior across restarts and recreation.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
📝 Walkthrough
📝 Walkthrough
Walkthrough
Adds end-to-end persistent-root storage checks for builtin and external MicroSandbox providers. The suite checks storage sizing, filesystem capacity, workspace-file persistence, and sandbox lifecycle behavior. CI runs the suite, and the provider parity documentation describes its scenarios and role.
Changes
MicroSandbox storage parity
Layer / File(s)
Summary
Storage sizing and persistence checks e2e/tests/up/provider_microsandbox_storage.go
Adds tests for default storage, provider storage overriding host requirements, and host requirements rounded up to whole GiB. Checks managed disk size and filesystem capacity. Verifies workspace markers across stop, restart, and recreation, and checks creation time and boot ID changes.
CI and parity documentation .github/workflows/pr-ci.yml, sites/docs-devsy-sh/content/docs/developing-providers/runtime-protocol.mdx
Adds the suite to the CI matrix with a 1200-second test timeout and a 25-minute job timeout. Documents the scenarios, run command, prerequisites, and parity-gate statements.
This change adds test coverage and documentation for MicroSandbox storage parity and does not alter runtime behavior. No actionable merge-blocking risk was identified.
Pre-merge checks | 4 | 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 …
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: adding runtime tests for MicroSandbox persistent storage parity.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 unsupported.)
Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
[Medium impact] The PR appears safe to merge; no actionable issue was found.
Summary
Adds persistent-storage checks for the built-in MicroSandbox driver and external provider v0.1.6.
MicroSandbox parity checks now cover root storage through VM recreation.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A["Create workspace"] --> B["Check root capacity and host file"]
B --> C["Write VM-local file"]
C --> D["Stop and start"]
D --> E["Check same creation time, new boot, and preserved files"]
E --> F["Recreate"]
F --> G["Check new creation time and boot"]
G --> H["Check VM-local file removed and host file preserved"]
Final head 104e439 passed all 76 implementation CI jobs, including all 36 selected MicroSandbox scenarios. Fresh Greptile is 5/5 and completed full CodeRabbit run 8d9ab549-5dd7-4b2d-9728-1088561efff7 covered all three PR files with no actionable findings or retained merge risks. There are no actionable review threads.
The generic docstring-coverage warning does not identify a missing public contract. These private E2E helpers have descriptive names and explicit assertions; the non-obvious filesystem-capacity allowance is commented, and the scenario contract is documented. Adding comments that merely restate each helper would not improve clarity. No code change is warranted for that warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MicroSandbox parity checks do not yet verify persistent root-disk capacity or its data lifecycle. Add the same three scenarios for the built-in driver and published external provider v0.1.6: the runtime default, explicit provider storage overriding host requirements, and fractional host storage rounded up when the provider value is zero.
Each scenario checks active root-disk configuration and actual guest filesystem capacity, then proves that a VM-local file survives stop/start and disappears after recreation while host workspace content persists. Creation time and boot IDs distinguish resume from replacement. A dedicated KVM CI entry uses the existing checksum-pinned MicroSandbox v0.7.7 setup, alongside all earlier parity suites.
Validation:
All 76 implementation CI jobs passed on 104e439, including the existing lifecycle, image, mount and resource suites plus the new storage suite (36 selected scenarios total). Fresh remote reviews are pending.
Ephemeral roots, network policy, prebuilds, Dockerless behavior, logs, cancellation and compatibility remain separate parity work. This PR does not change the default provider implementation.
Summary by CodeRabbit
Tests
Documentation