feat(eslint): disallow 'as' and non-null assertions#6
Draft
charliecreates[bot] wants to merge 1 commit into
Draft
feat(eslint): disallow 'as' and non-null assertions#6charliecreates[bot] wants to merge 1 commit into
charliecreates[bot] wants to merge 1 commit into
Conversation
Author
There was a problem hiding this comment.
No functional or stylistic problems were identified in the added configuration lines. The new rules align with the stated goal of disallowing direct type assertions and non-null assertions.
Summary of changes
🔧 ESLint Configuration Updates
- Added
@typescript-eslint/consistent-type-assertionswithassertionStyle: 'never'to ban bothasand angle-bracket type assertions. - Added
@typescript-eslint/no-non-null-assertionto forbid the!postfix operator. - Included explanatory comments for both new rules.
These changes strengthen type-safety by removing two escape hatches that can hide type errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Motivation
Adds lint rules to prevent TypeScript type assertions using `as` and the non-null assertion operator `!`, per Issue #5.
Changes
These rules are applied to all `.ts` and `.tsx` files.
Verification
`bun run lint` and `bun run typecheck` pass locally.
Closes #5