Skip to content

Conversation

@mbjorkqvist
Copy link
Contributor

@mbjorkqvist mbjorkqvist commented Nov 11, 2025

Add more details to the error message that is logged on the server side, and returned to the client, for the construction/payloads endpoint of ICP Rosetta. Also add some more detailed debug logging where the error occurs, to facilitate debugging.
E.g.,

2025-11-11T18:25:05.319170Z DEBUG rs/rosetta-api/icp/src/convert.rs:150: Error parsing operation type 'TRANSFER': Matching variant not found
2025-11-11T18:25:05.319465Z ERROR rs/rosetta-api/icp/src/rosetta_server.rs:213: Internal error: Error(Error { code: 730, message: "An invalid transaction has been detected", description: None, retriable: false, details: Some({"error_message": String("Error parsing operation type 'TRANSFER': Matching variant not found")}) })

instead of

2025-11-10T06:44:18.428798Z ERROR rs/rosetta-api/icp/src/rosetta_server.rs:213: Internal error: Error(Error { code: 700, message: "Internal server error", description: None, retriable: false, details: Some({"error_message": String("Failed to parse string: VariantNotFound")}) })

@github-actions github-actions bot added the chore label Nov 11, 2025
@mbjorkqvist mbjorkqvist marked this pull request as ready for review November 11, 2025 18:27
@mbjorkqvist mbjorkqvist requested a review from a team as a code owner November 11, 2025 18:27
@mbjorkqvist mbjorkqvist added this pull request to the merge queue Nov 19, 2025
Merged via the queue into master with commit 84d7d20 Nov 19, 2025
44 checks passed
@mbjorkqvist mbjorkqvist deleted the mathias-DEFI-2459-improve-icp-rosetta-logging-and-errors branch November 19, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants