fix(ckdoge): use correct transaction fees #7660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
changed the title
gregorydemay
commented
Nov 18, 2025
ninegua
reviewed
Nov 19, 2025
THLO
reviewed
Nov 19, 2025
THLO
reviewed
Nov 19, 2025
THLO
reviewed
Nov 19, 2025
THLO
reviewed
Nov 19, 2025
THLO
approved these changes
Nov 19, 2025
gregorydemay
commented
Nov 20, 2025
ninegua
approved these changes
Nov 20, 2025
mducroux
approved these changes
Nov 21, 2025
Contributor
mducroux
left a comment
mducroux
left a comment
There was a problem hiding this comment.
Thanks @gregorydemay, estimating fees looks much nicer now! Left only some nits
THLO
approved these changes
Nov 21, 2025
gregorydemay
commented
Nov 21, 2025
Contributor
Author
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @mducroux for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #7360 to use the correct parameters to compute the fees involved in a transaction sent by the minter to the Dogecoin network in case of a withdrawal.
The implementation introduces a new trait
FeeEstimator, of which there are two implementations (one for Bitcoin and another one for Dogecoin), and parametrize the existing methods to build transactions by an instance of that trait. A follow-up PR will add theestimate_withdrawal_feeendpoint.