Gabor/typtbl #5642
Gabor/typtbl #5642
Conversation
| let compile_add_const = compile_op_const I32Op.Add | ||
| let compile_sub_const = compile_op_const I32Op.Sub | ||
| let compile_mul_const = compile_op_const I32Op.Mul | ||
| let compile_mul_const = compile_op_const I32Op.Mul (* TODO: use shift: compile_mul_const 2l *) |
src/codegen/compile_enhanced.ml
Outdated
| (* Go! *) | ||
| Bool.lit extended ^^ Bool.to_rts_int32 ^^ get_data_buf ^^ get_typtbl_ptr ^^ get_typtbl_size_ptr ^^ get_maintyps_ptr ^^ | ||
| let tydesc, _, _ = type_desc env Candid ts in | ||
| let tydesc_len = Int64.of_int (String.length tydesc * 2 + 300) in |
There was a problem hiding this comment.
Don't limit when extended.
There was a problem hiding this comment.
May do it in the RTS, but we have to be careful to not reuse functions across this flag.
There was a problem hiding this comment.
Thinking about it, we could leave the rule in, as the type table is not expected to shrink considerably for orthogonal persistence between upgrades. Needs more thinking.
There was a problem hiding this comment.
Aaah ok, they are separated already: @deserialize_extended and @deserialize.
test/bench/ok/bignum.drun-run.ok
Outdated
| debug.print: {cycles = 2_509_532; size = +25_528} | ||
| ingress Completed: Reply: 0x4449444c0000 | ||
| debug.print: {cycles = 54_921_553; size = +830_464} | ||
| debug.print: {cycles = 54_921_579; size = +830_464} |
rts/motoko-rts/src/buf.rs
Outdated
| const WORD_SIZE: usize = core::mem::size_of::<u32>(); | ||
|
|
||
| if (*buf).ptr.add(WORD_SIZE - 1) >= (*buf).end { | ||
| // TODO: use add(WORD_SIZE) and > |
| const WORD_SIZE: usize = core::mem::size_of::<u32>(); | ||
|
|
||
| if (*buf).ptr.add(WORD_SIZE - 1) >= (*buf).end { | ||
| if (*buf).ptr.add(WORD_SIZE) > (*buf).end { |
There was a problem hiding this comment.
Allows CSE with line 58. Justified, because buf.ptr is a *mut u8.
src/codegen/compile_classical.ml
Outdated
| (* Go! *) | ||
| Bool.lit extended ^^ get_data_buf ^^ get_typtbl_ptr ^^ get_typtbl_size_ptr ^^ get_maintyps_ptr ^^ | ||
| let tydesc, _, _ = type_desc env ts in | ||
| let tydesc_len = Int32.of_int (String.length tydesc * 2 + 300) in |
There was a problem hiding this comment.
Make this a configurable affine function. See get/setCandidLimits primitives for an example.
1 participant
This PR TBW