-
Notifications
You must be signed in to change notification settings - Fork 510
Update docs to reflect 2TiB subnet memory capacity and 750GiB threshold #6003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The subnet memory capacity is increased to 2TiB in this PR and it has been rolled to mainnet. This PR updates the number in docs. |
|
we should make sure we catch all places that refer to this limit, e.g. here. ideally we find a solution that does not require this and we define constant in a single place we can refer to |
Thanks for pointing it out. I also updated other places. |
@letmejustputthishere That's a great idea. It seems I did not find existing patterns of setting constants and using it everywhere. Do you have any suggestions and I will happy to follow. Or I could figure out a new way of doing this. |
I don't think we're currently doing it in our docs, at least I haven't come across it. Would be really cool if you can find a way to achieve this 🤩 |
Hi @letmejustputthishere , I will try to find a way this week. What do you think of merging this PR first so that the doc becomes update-to-date as we have already publicly announced this change through media. And I will have some more time trying new ways. |
3df9a93 to
f6e1951
Compare
|
sounds good to me, feel free to merge this |
Thanks. FYI, I have tried several approaches in my new PR with the help of LLM as I did not have much experience with JS, but the preview link suggested they did not work well so far. |
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdxfile format to support the previous two components./sidebars.js, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERSfile iscontains any new directories or specific documents that you added that should be reviewed by a specific teamm.