Skip to content

Conversation

@ShuoWangNSL
Copy link
Contributor

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

@ShuoWangNSL ShuoWangNSL requested a review from a team as a code owner August 12, 2025 08:02
@github-actions github-actions bot added the documentation Changes to Developer Docs label Aug 12, 2025
@ShuoWangNSL
Copy link
Contributor Author

The subnet memory capacity is increased to 2TiB in this PR and it has been rolled to mainnet. This PR updates the number in docs.

@ShuoWangNSL ShuoWangNSL changed the title Update resource-limits.mdx Update resource-limits.mdx to reflect 2TiB subnet memory capacity Aug 12, 2025
@letmejustputthishere
Copy link
Contributor

we should make sure we catch all places that refer to this limit, e.g. here. ideally we find a solution that does not require this and we define constant in a single place we can refer to

@ShuoWangNSL ShuoWangNSL changed the title Update resource-limits.mdx to reflect 2TiB subnet memory capacity Update resource-limits.mdx to reflect 2TiB subnet memory capacity and 750GiB threshold Aug 12, 2025
@ShuoWangNSL
Copy link
Contributor Author

we should make sure we catch all places that refer to this limit, e.g. here

Thanks for pointing it out. I also updated other places.

@ShuoWangNSL
Copy link
Contributor Author

ideally we find a solution that does not require this and we define constant in a single place we can refer to

@letmejustputthishere That's a great idea. It seems I did not find existing patterns of setting constants and using it everywhere. Do you have any suggestions and I will happy to follow. Or I could figure out a new way of doing this.

@letmejustputthishere
Copy link
Contributor

That's a great idea. It seems I did not find existing patterns of setting constants and using it everywhere. Do you have any suggestions and I will happy to follow. Or I could figure out a new way of doing this.

I don't think we're currently doing it in our docs, at least I haven't come across it. Would be really cool if you can find a way to achieve this 🤩

@ShuoWangNSL ShuoWangNSL enabled auto-merge (squash) August 25, 2025 15:04
@ShuoWangNSL
Copy link
Contributor Author

I don't think we're currently doing it in our docs, at least I haven't come across it. Would be really cool if you can find a way to achieve this 🤩

Hi @letmejustputthishere , I will try to find a way this week. What do you think of merging this PR first so that the doc becomes update-to-date as we have already publicly announced this change through media. And I will have some more time trying new ways.

@ShuoWangNSL ShuoWangNSL force-pushed the shuo/bump_state_size_2TiB branch from 3df9a93 to f6e1951 Compare August 30, 2025 01:01
@ShuoWangNSL ShuoWangNSL changed the title Update resource-limits.mdx to reflect 2TiB subnet memory capacity and 750GiB threshold Update docs to reflect 2TiB subnet memory capacity and 750GiB threshold Aug 30, 2025
@letmejustputthishere
Copy link
Contributor

sounds good to me, feel free to merge this

@ShuoWangNSL
Copy link
Contributor Author

sounds good to me, feel free to merge this

Thanks. FYI, I have tried several approaches in my new PR with the help of LLM as I did not have much experience with JS, but the preview link suggested they did not work well so far.

@ShuoWangNSL ShuoWangNSL disabled auto-merge September 1, 2025 15:54
@ShuoWangNSL ShuoWangNSL enabled auto-merge (squash) September 1, 2025 15:54
@ShuoWangNSL ShuoWangNSL disabled auto-merge September 1, 2025 15:54
@ShuoWangNSL ShuoWangNSL enabled auto-merge (squash) September 1, 2025 15:55
@ShuoWangNSL ShuoWangNSL merged commit 9b8694d into master Sep 1, 2025
6 checks passed
@ShuoWangNSL ShuoWangNSL deleted the shuo/bump_state_size_2TiB branch September 1, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Changes to Developer Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants