Skip to content

chore(deps-dev): bump vitest from 5.0.0 to 5.0.5 - #4945

Merged
ocs-percy merged 1 commit into
mainfrom
dependabot/npm_and_yarn/vitest-5.0.5
Nov 2, 2026
Merged

ocs-percy merged 1 commit into
mainfrom
dependabot/npm_and_yarn/vitest-5.0.5

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 2, 2026

Copy link
Copy Markdown
Contributor

Bumps vitest from 5.0.0 to 5.0.5.

Release notes

Sourced from vitest's releases.

v5.0.5

   🐞 Bug Fixes

    View changes on GitHub

v5.0.4

   🚀 Features

   🐞 Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 5.0.0 to 5.0.5.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 5.0.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 2, 2026
@claude

claude Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Dependency Analysis Summary

Package Old New Type
vitest (dev) 5.0.0 5.0.5 PATCH
@vitest/mocker, @vitest/spy 5.0.0 5.0.5 transitive
chai 6.2.2 6.3.0 transitive
obug 2.2.1 3.0.0 transitive (vitest-internal debug logger)
magic-string 1.3.1 1.4.5 transitive
std-env 4.2.0 → 4.3.0, tinybench 6.1.4 → 6.2.2, tinyexec 1.3.0 → 1.3.1, @types/estree +1.0.10 transitive
siginfo, stackback removed transitive

Overall risk: LOW. This is a dev-only test runner. Nothing ships to production.

📋 Detailed Changelog Review

vitest 5.0.0 → 5.0.5

Transitive bumps: obug 3.0.0 is a major bump, but vitest only uses it for internal debug logging and OCS never imports it. The other bumps are minor or patch.

⚠️ Impact Assessment

  • Breaking changes found: No.
  • Affected files: None. vitest.config.mjs uses only include, environment: jsdom and setupFiles, all unchanged. The 18 spec files under assets/javascript/ use describe/it/expect, vi.mock, vi.fn and afterEach. They call no changed APIs.
  • Test impact: I ran pnpm test locally on this branch with vitest v5.0.5: 18 files, 223 tests passed (6.5s).
  • Configuration changes: None needed.

🛠️ Recommendations

  • Action required: None.
  • Testing focus: The CI JS test job is enough. The local run already passes.
  • Follow-up (optional): Vitest now prints a hint that jsdom setup takes about 58% of run time and suggests pool: vmThreads or isolate: false. It is not needed at the current suite size.
  • Merge recommendation: ✅ APPROVE

📚 Useful Links

@ocs-percy ocs-percy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 3ead393: chore(deps-dev): bump vitest from 5.0.0 to 5.0.5.

Changes: package.json (+1 -1), pnpm-lock.yaml (+55 -63). The automated review rated it low risk. All 12 other CI checks on this exact head pass, including python-tests, e2e-tests, build-frontend and code-style.

One check is red, and it is not about this PR: sync-eslint-pins fails at its Generate app token step with "[universal-github-app-jwt] Private Key is in OpenSSH format, but only PKCS#8 is supported" (I read the log of this run). That workflow only rewrites the pre-commit eslint pins, and this PR does not touch eslint or typescript-eslint, so it would have been a no-op. The OCS_AGENT_PRIVATE_KEY secret under Dependabot secrets needs converting to PKCS#8.

Not done: manual smoke tests. I am relying on CI, the diff and the review.

@ocs-percy
ocs-percy merged commit cc7f1a2 into main Nov 2, 2026
23 of 24 checks passed
@ocs-percy
ocs-percy deleted the dependabot/npm_and_yarn/vitest-5.0.5 branch November 2, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code risk:high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant