fix: guard constructTweet against undefined full_text#1267
Merged
dimdenGD merged 1 commit intoMay 11, 2026
Conversation
The longShortClass calculation reads t.full_text.length without a guard, throwing a TypeError when a tweet object has no full_text property (observed in v1.9.6.5 during renderTimeline on profile pages). Fall back to length 0 when full_text is missing so the class assignment matches the existing short-tweet behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1252.
constructTweetreadst.full_text.lengthwhile computing thelongShortClassfor the body element, but the tweet object can lack afull_textproperty in some timeline contexts, which crashes with:Using
t.full_text?.length ?? 0keeps the behaviour identical for normal tweets (length compared against 280) and falls back to the short-tweet branch whenfull_textis missing, preserving the existing styling instead of crashing the timeline render.