feat!: have most shape queries return the SubShapeId to identify the parts of a composite shape involved - #443
Open
sebcrozet wants to merge 2 commits into
Open
feat!: have most shape queries return the SubShapeId to identify the parts of a composite shape involved#443sebcrozet wants to merge 2 commits into
sebcrozet wants to merge 2 commits into
Conversation
…parts of a composite shape involved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, it could be fairly difficult (or impossible) to know which part of a compound/trimesh/polyline/voxels shape was tied to a geometric query result. Now most queries include the subshape id (which is set to 0 for primitive shapes).