-
Notifications
You must be signed in to change notification settings - Fork 4
chore: Prepeare release 1.0.0 #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePrepares the project for the 1.0.0 release by bumping the package version constant and touching the changelog file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 19 19
Lines 886 886
Branches 100 100
=======================================
Hits 815 815
Misses 44 44
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The PR title contains a typo (
Prepeare); consider correcting it toPreparefor clarity in release history.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title contains a typo (`Prepeare`); consider correcting it to `Prepare` for clarity in release history.
## Individual Comments
### Comment 1
<location> `CHANGELOG.rst:25` </location>
<code_context>
+* fix: Respect ?preview for menu views by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/70
+* fix: Check for toolbar attribute before setting preview mode on `?preview=1` request by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/71
+* fix: try to fix the issue with coverage files not uploading by @vinitkumar in https://github.com/django-cms/djangocms-rest/pull/74
+* fix: readthedoc build by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/76
+* fix: Add page path to node attributes by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/78
+* fix: Add tests to verify caching behavior by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/85
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing `readthedoc` to `readthedocs` for consistency with the earlier entry and the service name.
Using the plural form here ("readthedocs build") will match "readthedocs support" used earlier and align with the official service name, avoiding the appearance of a typo.
```suggestion
* fix: readthedocs build by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/76
```
</issue_to_address>
### Comment 2
<location> `CHANGELOG.rst:18` </location>
<code_context>
+* feat: add package data configuration for static and template files by @metaforx in https://github.com/django-cms/djangocms-rest/pull/81
+* feat: Add page search endpoint by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/64
+* feat: Preserve placeholder order by @metaforx in https://github.com/django-cms/djangocms-rest/pull/83
+* refactor: add distinct operationId in openapi schema for menu endpoin… by @metaforx in https://github.com/django-cms/djangocms-rest/pull/80
+* fix: OpenAPI schema for nested navigation by @metaforx in https://github.com/django-cms/djangocms-rest/pull/58
+* fix: Page serializer returned null for empty meta_description by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/56
</code_context>
<issue_to_address>
**issue (typo):** The word `endpoin…` appears truncated; consider changing it to `endpoint`.
The trailing ellipsis makes this look like a mistakenly truncated `endpoint`, likely copied from a shortened title. Using the full word would read more clearly.
```suggestion
* refactor: add distinct operationId in openapi schema for menu endpoint by @metaforx in https://github.com/django-cms/djangocms-rest/pull/80
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| * fix: Respect ?preview for menu views by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/70 | ||
| * fix: Check for toolbar attribute before setting preview mode on `?preview=1` request by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/71 | ||
| * fix: try to fix the issue with coverage files not uploading by @vinitkumar in https://github.com/django-cms/djangocms-rest/pull/74 | ||
| * fix: readthedoc build by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Consider changing readthedoc to readthedocs for consistency with the earlier entry and the service name.
Using the plural form here ("readthedocs build") will match "readthedocs support" used earlier and align with the official service name, avoiding the appearance of a typo.
| * fix: readthedoc build by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/76 | |
| * fix: readthedocs build by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/76 |
| * feat: add package data configuration for static and template files by @metaforx in https://github.com/django-cms/djangocms-rest/pull/81 | ||
| * feat: Add page search endpoint by @fsbraun in https://github.com/django-cms/djangocms-rest/pull/64 | ||
| * feat: Preserve placeholder order by @metaforx in https://github.com/django-cms/djangocms-rest/pull/83 | ||
| * refactor: add distinct operationId in openapi schema for menu endpoin… by @metaforx in https://github.com/django-cms/djangocms-rest/pull/80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): The word endpoin… appears truncated; consider changing it to endpoint.
The trailing ellipsis makes this look like a mistakenly truncated endpoint, likely copied from a shortened title. Using the full word would read more clearly.
| * refactor: add distinct operationId in openapi schema for menu endpoin… by @metaforx in https://github.com/django-cms/djangocms-rest/pull/80 | |
| * refactor: add distinct operationId in openapi schema for menu endpoint by @metaforx in https://github.com/django-cms/djangocms-rest/pull/80 |
Summary by Sourcery
Enhancements: