Skip to content

Conversation

@the-horo
Copy link
Contributor

@the-horo the-horo commented Jul 6, 2025

No description provided.

@the-horo the-horo requested a review from CyberShadow as a code owner July 6, 2025 10:34
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + tools#482"

@thewilsonator thewilsonator changed the title CI: bump setup-dlanb to v2 CI: bump setup-dlang to v2 Jul 6, 2025
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You typo'd the commit title and PR title. I fixed the PR title, please fix the commit title.

a51571a changed the help text output
leading leading to test failures

Signed-off-by: Andrei Horodniceanu <[email protected]>
@the-horo the-horo requested a review from andralex as a code owner July 6, 2025 10:45
@the-horo the-horo force-pushed the setup-dlang-v2 branch 2 times, most recently from 7964dbb to 6b1e240 Compare July 6, 2025 10:50
Signed-off-by: Andrei Horodniceanu <[email protected]>
@the-horo the-horo force-pushed the setup-dlang-v2 branch 3 times, most recently from 2730464 to b0fa2d6 Compare July 6, 2025 11:07
Signed-off-by: Andrei Horodniceanu <[email protected]>
@the-horo the-horo force-pushed the setup-dlang-v2 branch 2 times, most recently from 39bb436 to 52ea53d Compare July 6, 2025 12:17
@the-horo
Copy link
Contributor Author

the-horo commented Jul 6, 2025

Is it possible to enable the workflow to run every time? Currently main.yml is not being run and I'm looking at the failures in my fork

@the-horo
Copy link
Contributor Author

the-horo commented Jul 6, 2025

c39bd46 is fixing a current test failure, should it be targeting stable?

@the-horo the-horo mentioned this pull request Jul 6, 2025
@thewilsonator
Copy link
Contributor

Is it possible to enable the workflow to run every time?

Maybe? It is not run by default for first-time contributors (which you are for this repo), so I am manually approving it.

c39bd46 is fixing a current test failure, should it be targeting stable?

It could, I don't see any harm in doing so.

@the-horo
Copy link
Contributor Author

the-horo commented Jul 6, 2025

It could, I don't see any harm in doing so.

Not doing it would mean that make test will fail on the next release, right?

@thewilsonator
Copy link
Contributor

yes

@the-horo
Copy link
Contributor Author

the-horo commented Jul 6, 2025

nvm, stable has been fixed in #480

@thewilsonator
Copy link
Contributor

Is this good to go? If not, ping me when it is

@the-horo
Copy link
Contributor Author

the-horo commented Jul 6, 2025

Fine with me

@thewilsonator thewilsonator merged commit 829e771 into dlang:master Jul 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants