Fixes for azure-mgmt-dns==8.0.0

[vladwing]

• Need to read JSON/Auth file manually
• API for iterating resources is changed/simplified

[jcollie]

This patch fixes my problems with using Azure DNS & Let's Encrypt. I hope that it can be merged soon.

[vladwing]

@jcollie I didn't need the requirements you mention. Can you share your os and command you were running to figure out where the gap is?

[jcollie]

@jcollie I didn't need the requirements you mention. Can you share your os and command you were running to figure out where the gap is?

I was testing on a CentOS 7 system using the Python 3.6 packages.

[root@annfa01 ~]# python3 -m venv /opt/cb2
[root@annfa01 ~]# /opt/cb2/bin/pip install --upgrade pip
Collecting pip
  Using cached https://files.pythonhosted.org/packages/ca/31/b88ef447d595963c01060998cb329251648acf4a067721b0452c45527eb8/pip-21.2.4-py3-none-any.whl
Installing collected packages: pip
  Found existing installation: pip 9.0.3
    Uninstalling pip-9.0.3:
      Successfully uninstalled pip-9.0.3
Successfully installed pip-21.2.4
[root@annfa01 ~]# /opt/cb2/bin/pip install --upgrade setuptools
Requirement already satisfied: setuptools in /opt/cb2/lib/python3.6/site-packages (39.2.0)
Collecting setuptools
  Using cached setuptools-57.4.0-py3-none-any.whl (819 kB)
Installing collected packages: setuptools
  Attempting uninstall: setuptools
    Found existing installation: setuptools 39.2.0
    Uninstalling setuptools-39.2.0:
      Successfully uninstalled setuptools-39.2.0
Successfully installed setuptools-57.4.0
[root@annfa01 ~]# /opt/cb2/bin/pip install --upgrade git+https://github.com/vladwing/certbot-azure@master
Collecting git+https://github.com/vladwing/certbot-azure@master
  Cloning https://github.com/vladwing/certbot-azure (to revision master) to /tmp/pip-req-build-5ubm8h4o
  Running command git clone -q https://github.com/vladwing/certbot-azure /tmp/pip-req-build-5ubm8h4o
  Resolved https://github.com/vladwing/certbot-azure to commit 85e0da499d313431bcd47ae39e0e4c88bf2c2561
Collecting acme>=0.29.0
  Using cached acme-1.18.0-py2.py3-none-any.whl (43 kB)
Collecting certbot>=1.1.0
  Using cached certbot-1.18.0-py2.py3-none-any.whl (258 kB)
Collecting azure-mgmt-resource
  Using cached azure_mgmt_resource-19.0.0-py2.py3-none-any.whl (2.2 MB)
Collecting azure-mgmt-network
  Using cached azure_mgmt_network-19.0.0-py2.py3-none-any.whl (20.9 MB)
Collecting azure-mgmt-dns>=3.0.0
  Using cached azure_mgmt_dns-8.0.0-py2.py3-none-any.whl (118 kB)
Collecting PyOpenSSL>=19.1.0
  Using cached pyOpenSSL-20.0.1-py2.py3-none-any.whl (54 kB)
Requirement already satisfied: setuptools in /opt/cb2/lib/python3.6/site-packages (from certbot-azure==0.1.1) (57.4.0)
Collecting zope.interface
  Using cached zope.interface-5.4.0-cp36-cp36m-manylinux2010_x86_64.whl (251 kB)
Collecting mock
  Using cached mock-4.0.3-py3-none-any.whl (28 kB)
Collecting requests>=2.14.2
  Using cached requests-2.26.0-py2.py3-none-any.whl (62 kB)
Collecting pytz
  Using cached pytz-2021.1-py2.py3-none-any.whl (510 kB)
Collecting chardet
  Using cached chardet-4.0.0-py2.py3-none-any.whl (178 kB)
Collecting requests-toolbelt>=0.3.0
  Using cached requests_toolbelt-0.9.1-py2.py3-none-any.whl (54 kB)
Collecting cryptography>=2.1.4
  Using cached cryptography-3.4.7-cp36-abi3-manylinux2014_x86_64.whl (3.2 MB)
Collecting pyrfc3339
  Using cached pyRFC3339-1.1-py2.py3-none-any.whl (5.7 kB)
Collecting josepy>=1.1.0
  Using cached josepy-1.8.0-py2.py3-none-any.whl (61 kB)
Collecting azure-mgmt-core<2.0.0,>=1.2.0
  Using cached azure_mgmt_core-1.3.0-py2.py3-none-any.whl (25 kB)
Collecting msrest>=0.6.21
  Using cached msrest-0.6.21-py2.py3-none-any.whl (85 kB)
Collecting azure-common~=1.1
  Using cached azure_common-1.1.27-py2.py3-none-any.whl (12 kB)
Collecting azure-core<2.0.0,>=1.15.0
  Using cached azure_core-1.17.0-py2.py3-none-any.whl (165 kB)
Collecting six>=1.11.0
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting parsedatetime>=2.4
  Using cached parsedatetime-2.6-py3-none-any.whl (42 kB)
Collecting ConfigArgParse>=0.9.3
  Using cached ConfigArgParse-1.5.2-py3-none-any.whl (20 kB)
Collecting zope.component
  Using cached zope.component-5.0.1-py2.py3-none-any.whl (68 kB)
Collecting distro>=1.0.1
  Using cached distro-1.6.0-py2.py3-none-any.whl (19 kB)
Collecting configobj>=5.0.6
  Using cached configobj-5.0.6-py3-none-any.whl
Collecting cffi>=1.12
  Using cached cffi-1.14.6-cp36-cp36m-manylinux1_x86_64.whl (401 kB)
Collecting pycparser
  Using cached pycparser-2.20-py2.py3-none-any.whl (112 kB)
Collecting isodate>=0.6.0
  Using cached isodate-0.6.0-py2.py3-none-any.whl (45 kB)
Collecting requests-oauthlib>=0.5.0
  Using cached requests_oauthlib-1.3.0-py2.py3-none-any.whl (23 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2021.5.30-py2.py3-none-any.whl (145 kB)
Collecting idna<4,>=2.5
  Using cached idna-3.2-py3-none-any.whl (59 kB)
Collecting urllib3<1.27,>=1.21.1
  Using cached urllib3-1.26.6-py2.py3-none-any.whl (138 kB)
Collecting charset-normalizer~=2.0.0
  Using cached charset_normalizer-2.0.4-py3-none-any.whl (36 kB)
Collecting oauthlib>=3.0.0
  Using cached oauthlib-3.1.1-py2.py3-none-any.whl (146 kB)
Collecting zope.event
  Using cached zope.event-4.5.0-py2.py3-none-any.whl (6.8 kB)
Collecting zope.hookable>=4.2.0
  Using cached zope.hookable-5.1.0-cp36-cp36m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (27 kB)
Using legacy 'setup.py install' for certbot-azure, since package 'wheel' is not installed.
Installing collected packages: pycparser, cffi, urllib3, six, idna, cryptography, charset-normalizer, certifi, requests, pytz, PyOpenSSL, oauthlib, zope.interface, zope.hookable, zope.event, requests-toolbelt, requests-oauthlib, pyrfc3339, josepy, isodate, chardet, azure-core, zope.component, parsedatetime, msrest, distro, configobj, ConfigArgParse, azure-mgmt-core, azure-common, acme, mock, certbot, azure-mgmt-resource, azure-mgmt-network, azure-mgmt-dns, certbot-azure
    Running setup.py install for certbot-azure ... done
Successfully installed ConfigArgParse-1.5.2 PyOpenSSL-20.0.1 acme-1.18.0 azure-common-1.1.27 azure-core-1.17.0 azure-mgmt-core-1.3.0 azure-mgmt-dns-8.0.0 azure-mgmt-network-19.0.0 azure-mgmt-resource-19.0.0 certbot-1.18.0 certbot-azure-0.1.1 certifi-2021.5.30 cffi-1.14.6 chardet-4.0.0 charset-normalizer-2.0.4 configobj-5.0.6 cryptography-3.4.7 distro-1.6.0 idna-3.2 isodate-0.6.0 josepy-1.8.0 mock-4.0.3 msrest-0.6.21 oauthlib-3.1.1 parsedatetime-2.6 pycparser-2.20 pyrfc3339-1.1 pytz-2021.1 requests-2.26.0 requests-oauthlib-1.3.0 requests-toolbelt-0.9.1 six-1.16.0 urllib3-1.26.6 zope.component-5.0.1 zope.event-4.5.0 zope.hookable-5.1.0 zope.interface-5.4.0
[root@annfa01 ~]# /opt/cb2/bin/pip list
Package             Version
------------------- ---------
acme                1.18.0
azure-common        1.1.27
azure-core          1.17.0
azure-mgmt-core     1.3.0
azure-mgmt-dns      8.0.0
azure-mgmt-network  19.0.0
azure-mgmt-resource 19.0.0
certbot             1.18.0
certbot-azure       0.1.1
certifi             2021.5.30
cffi                1.14.6
chardet             4.0.0
charset-normalizer  2.0.4
ConfigArgParse      1.5.2
configobj           5.0.6
cryptography        3.4.7
distro              1.6.0
idna                3.2
isodate             0.6.0
josepy              1.8.0
mock                4.0.3
msrest              0.6.21
oauthlib            3.1.1
parsedatetime       2.6
pip                 21.2.4
pycparser           2.20
pyOpenSSL           20.0.1
pyRFC3339           1.1
pytz                2021.1
requests            2.26.0
requests-oauthlib   1.3.0
requests-toolbelt   0.9.1
setuptools          57.4.0
six                 1.16.0
urllib3             1.26.6
zope.component      5.0.1
zope.event          4.5.0
zope.hookable       5.1.0
zope.interface      5.4.0
[root@annfa01 ~]# /opt/cb2/bin/python
Python 3.6.8 (default, Nov 16 2020, 16:55:22) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-44)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import azure.identity
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'azure.identity'
>>> import msrestazure
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'msrestazure'
>>> 

[AmyJeanes]

This has been working great for me, can we please get this merged in? certbot-azure is completely broken without these changes