Skip to content

Conversation

@heaven00
Copy link
Collaborator

@heaven00 heaven00 commented Nov 26, 2025

Cleaned up branch of #12

@heaven00 heaven00 mentioned this pull request Nov 26, 2025
7 tasks
@heaven00 heaven00 requested a review from zilto November 27, 2025 04:34
@heaven00
Copy link
Collaborator Author

@zilto I am not 100% sure at the moment why the ty-checks have started to fail suddenly at the moment and it's a bit too late for me to figure it out if you get a chance to look at it check it out else I will get to it later in the day tomorrow after class

src/dlt_mcp/_utilities/ingestion.py:42:9: error[invalid-method-override] Invalid override of method `generate_embeddings`: Definition is incompatible with `TextEmbeddingFunction.generate_embeddings`
  tests/conftest.py:17:16: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/conftest.py:32:29: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/conftest.py:34:6: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_core.py:9:19: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_core.py:43:62: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_core.py:62:64: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_core.py:82:19: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_display_schema.py:7:19: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_display_schema.py:26:19: error[invalid-type-form] Variable of type `Never` is not allowed in a type expression
  tests/tools/test_search.py:17:28: warning[possibly-missing-import] Member `search` of module `dlt_mcp._tools` may be missing
  tests/tools/test_search.py:45:45: error[invalid-argument-type] Argument to function `page_chunks_table` is incorrect: Expected `list[dict[str, str]]`, found `list[dict[str, str | int | list[int | float | Unknown]] | Unknown]`
  tests/tools/test_search.py:65:45: error[invalid-argument-type] Argument to function `code_chunks_table` is incorrect: Expected `list[dict[str, str]]`, found `list[dict[str, str | int | list[int | float | Unknown]] | Unknown]`
  Found 13 diagnostics

@heaven00
Copy link
Collaborator Author

heaven00 commented Nov 27, 2025

@zilto all yours for now, two important things that we need to tackle

  • wait for devel to release this week and freeze the dlt version moved it to devel for now
  • at the moment i add uv run ty check --exclude tests --output-format concise . because I tackling them is taking a lot of time and I would prefer tackling them later in another PR.

…lxed dlt version after to_mermaid feature is launched in main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants