Skip to content

fix: hyphens are not valid in identifiers in template expressions#87

Open
forivall wants to merge 4 commits intodlvandenberg:mainfrom
forivall:no-hyphen-in-template-expression-identifiers
Open

fix: hyphens are not valid in identifiers in template expressions#87
forivall wants to merge 4 commits intodlvandenberg:mainfrom
forivall:no-hyphen-in-template-expression-identifiers

Conversation

@forivall
Copy link
Copy Markdown

This change also is the beginning of a separation between the parsing of the binding attributes (as defined in the angular compiler's binding_parser.ts ) from the expression parser, as identifiers in expressions are much stricter than what is allowed in parsing html attribute names (which are then parsed by the binding parser, as seen above)

@dlvandenberg
Copy link
Copy Markdown
Owner

Hi @forivall ! Thanks for the contribution :) Can you update the version in package.json, Cargo.toml and pyproject.toml to the new patch version? Make sure to also run cargo build and npm run build

@forivall forivall force-pushed the no-hyphen-in-template-expression-identifiers branch from 705eae0 to 0354d50 Compare April 17, 2026 03:22
@forivall
Copy link
Copy Markdown
Author

FYI, the force push just updated the formatting of my test changes with tree-sitter test --update. There were a few other tests which also arent canonically formatted, which could also be updated.

also, as i mention in the commit, to update the version seamlessly, i ran

tree-sitter version --bump patch && tree-sitter build && cargo build && npm i

note that i had to manually change the version in tree-sitter.json to the current version before it worked properly, as that version was out of date. the tree-sitter version --bump also updated the version in the Makefile, and updating the tree-sitter.json also makes the parser.c embed the version properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants