Rewrite the example configs too (code.globs) - #286
Conversation
`luria concretize` rewrites the files `code.globs` names, and this repository's own list did not name `examples/**/*.yaml`. ADR-111 therefore landed on main as a live `ADR-tmp92495` in the knowledge-base example. Nothing caught it and nothing could: a temporary code goes on resolving through the successor's `formerly:` entry, which is what that field is for. The only symptom was a shipped example config reading as though it had been authored halfway through a branch. Seven example configs come into the rewrite set. Verified by comparing the collected file set before and after, and by running a concretize end to end against a temporary code cited from the example. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeX27AYgHU7geZaYkwshBS
|
Checked whether
Same failure, same cause, one file class over: a decision-dense file outside That's an argument for going further than this PR does. I've added Generated by Claude Code |
Cleaning up after myself: #285 left a live temporary code on
main.luria concretizerewrites the filescode.globsnames, and this repository's own list doesn't nameexamples/**/*.yaml. So ADR-111 landed asADR-tmp92495inexamples/knowledge-base/luria.yaml— the.pyfiles were rewritten correctly, the example config wasn't.Nothing caught it, and nothing could. A temporary code goes on resolving through the successor's
formerly:entry, which is exactly what that field is for, soluria lintis clean and the unresolved-codes report is unchanged. The only symptom is a shipped example reading as though it were authored halfway through a branch.Two changes:
examples/**/*.yamladded tocode.globs— brings 7 example configs into the rewrite setADR-tmp92495→ADR-111Verified
Before/after on the collected file set:
examples/knowledge-base/luria.yamlgoesFalse→True.And end to end, because the file set being right doesn't prove the rewrite happens — a scratch ADR cited from the example config, then
luria concretize:with the example rewritten from
(ADR-111, ADR-tmp5mzvb)to(ADR-111, ADR-112). Scratch reset afterwards; ADR-112 is not in this branch.Full suite 1335 passed / 33 skipped. No views committed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FeX27AYgHU7geZaYkwshBS
Generated by Claude Code