Run meta job from git triggers #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
approved these changes
Feb 27, 2025
tianon
reviewed
Feb 28, 2025
| pipelineTriggers([ | ||
| cron('@hourly'), | ||
| githubPush(), | ||
| cron('@daily'), // check periodically, just in case |
Member
There was a problem hiding this comment.
We have to move this back to @hourly for now so we can pick up completed builds (until we figure out / implement a better way to have those triggers make their way back into the system).
tianon
added a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current git commit to image on
library/build and publish pipeline looks like this:meta -> trigger -> build -> meta -> deploy -> put-sharedWith meta needing to reconcile
souces.jsonandbuilds.jsonso that builds can be triggered and so that deploy can push from staging to arch-specific namespaces, if we run it more often, we can improve the "time to pullable" fromlibraryon Docker Hub.Still a TODO: skipping behavior since this will no longer be guaranteed hourly triggers (and often could be more than hourly)