switch to ESM and update config/test wiring#961
Merged
crazy-max merged 5 commits intodocker:mainfrom Jan 28, 2026
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
commented
Jan 28, 2026
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "module": "es2020", | |||
Member
Author
There was a problem hiding this comment.
Can't use nodenext yet because of @actions/artifact/lib imports:
Lines 23 to 27 in f64486a
Tried to vendor it but then Jest fails so would need to migrate Jest which will be used to transform files into valid JS based on Babel configuration without need of ts-type.
Member
Author
There was a problem hiding this comment.
This could be easily solved in the future with actions/toolkit#2256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for #960
https://github.com/docker/actions-toolkit/actions/runs/21432262600/job/61714304782?pr=960#step:2:333