fix: A2A error handling + cross-platform test stability#3751
Closed
aheritier wants to merge 1 commit into
Closed
Conversation
- Detect and return an error when the A2A agent returns no text content - Fix cross-platform test stability with writeMockScript helper for Windows - Fix TestForWorkspace_SbxBackend to use cat+datafile pattern (proper JSON quoting) - Fix TestToolSetEmptyStreamReturnsError: handler must emit final TaskStateCompleted event - Add Windows skip guards for POSIX shell-dependent compaction tests - Fix import paths to use filepath.Abs for cross-platform compatibility Co-authored-by: Piyush0049 <piyushjoshi81204@gmail.com>
aheritier
added
area/a2a
dgageot
approved these changes
Jul 20, 2026
aheritier
added
the
status/ready-for-review
Contributor
Author
|
I never asked to create such PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3745 (which can no longer be pushed to its fork branch from CI).
What changed vs #3745: Same functional changes, plus lint and test fixes that failed after rebase onto main (post-#3739).
Lint fixes:
perfsprint:fmt.Sprintf("echo %s", jsonData)→ string concatenation (sandbox_test.go:168)gci/gofumpt: remove spaces around+in string concatenation (agent_delegation_test.go:44)gci/gofmt: remove trailing tab on blank line inwriteMockScript(sandbox_test.go:300)Test fixes:
TestForWorkspace_SbxBackend: usecat <datafile>pattern (same asTestForWorkspace) instead of bareecho, which stripped JSON double-quotes in the shell scriptTestToolSetEmptyStreamReturnsError:testEmptyA2AHandler.Executemust emit a finalTaskStateCompletedevent — without it the a2a event pipe never closes, causing the HTTP client to timeout waiting for response headers (30s)Functional changes (from #3745):
ResultError("No response from agent")instead ofResultSuccess("")when stream yields no textwriteMockScripthelper for cross-platform sandbox testsfilepath.Absusage for cross-platform path assertionsTested locally: all affected tests pass.