Clean supported metadata driver types - #948
Merged
Merged
Conversation
GromNaN
commented
Nov 14, 2025
| throw new InvalidArgumentException(sprintf('Specified non-existing directory "%s" as Doctrine mapping source.', $mappingConfig['dir'])); | ||
| } | ||
|
|
||
| if (! in_array($mappingConfig['type'], ['xml', 'php', 'staticphp', 'attribute'])) { |
Member
Author
There was a problem hiding this comment.
Using php or static php currently fails in
DoctrineMongoDBBundle/src/DependencyInjection/DoctrineMongoDBExtension.php
Lines 1021 to 1029 in a4279b1
GromNaN
force-pushed
the
driver-types
branch
from
November 14, 2025 17:07
a4279b1 to
0f7550d
Compare
jmikola
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #923, we can cleanup some legacy.
ymlformat isn't supported since MongoDB ODM v2phpandstaticphpformat have never been supported by the bundle itself. They require a custom driver configuration (see Static PHP config #936)