add initial native impl by stelzo · Pull Request #117 · dofusdude/doduda

stelzo · 2026-04-12T23:12:46Z

fixes #114

Copilot

Pull request overview

Adds an initial native (non-Docker) implementation for Dofus 3 Unity bundle/image/i18n unpacking to avoid Docker Desktop UID/GID issues on Windows (fixes #114), while keeping a Docker backend available via DODUDA_UNITY_BACKEND.

Changes:

Introduce Unity unpack backend abstraction with native as default and docker as opt-in.
Implement native Unity bundle decoding, imagebundle extraction, and i18n .bin parsing (plus a native i18n test).
Add a mapping-time normalization step to rewrite rid fields to strings for Unity JSON inputs.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
update.go	Switch Unity bundle/image unpacking to backend selection; image pulls now via backend `Prepare`.
unity_backend.go	Adds backend selection via `DODUDA_UNITY_BACKEND` (default native).
unity_backend_native.go	Native backend adapter wiring into new native unpackers.
unity_backend_docker.go	Docker backend moved here (container-based bundle/image unpack + image pulling).
unity_bundle_native.go	Native UnityFS bundle reader + type tree decoding into JSON.
unity_imagebundle_native.go	Native `.imagebundle` sprite/texture extraction and PNG writing.
unity_i18n_native.go	Native localization `.bin` to JSON converter.
unity_i18n_native_test.go	Test covering native i18n conversion using an on-repo fixture.
mapping.go	Adds RID normalization pass over Unity raw JSON files prior to parsing.
images.go	Adds fallback logic for directory layout differences between backends.
README.md	Updates docs to reflect native Dofus 3 unpacking and Docker being optional/legacy.
go.mod / go.sum	Adds deps required for native Unity decoding/decompression and texture handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-12T23:18:17Z

+	feedbacks := make(chan string)
+
+	var feedbackWg sync.WaitGroup
+	if !muteSpinner {
+		feedbackWg.Add(1)


PullImages creates an unbuffered feedbacks channel and only starts a consumer goroutine when muteSpinner is false. If muteSpinner is true, any send to feedbacks later in the function will block forever. Consider buffering the channel, always consuming it, or guarding sends when muteSpinner is true.

Copilot · 2026-04-12T23:18:18Z

+		_, err = io.ReadAll(imageHandle)
+		if err != nil {
+			log.Fatalf("Error finishing image handler: %v", err)
+		}


PullImages returns an error in its signature, but io.ReadAll errors currently call log.Fatalf which terminates the process and skips caller error handling. Prefer returning the error (wrapped with context) instead of exiting.

Copilot · 2026-04-12T23:18:18Z

-	feedbackWg.Wait()
-
-	return nil
+	return unpackUnityI18nNative(inputPath, outputPath)


UnpackUnityI18n bypasses the selected Unity backend and always uses the native implementation, even when DODUDA_UNITY_BACKEND=docker is set. If users force the Docker backend for consistency/workarounds, this behavior is surprising; consider routing i18n unpacking through the backend selection as well (e.g., add it to UnityUnpackBackend).

Copilot · 2026-04-12T23:18:18Z

+						errorChan <- err
+					}
+				} else if errors.Is(err, os.ErrNotExist) {
+					if _, toErr := os.Stat(toPath); toErr != nil {


This fallback branch triggers on any error from os.Stat(toPath), not just "not exists". For example, permission or transient IO errors would incorrectly send the code down the native-backend fallback path. Consider checking errors.Is(toErr, os.ErrNotExist) explicitly (and returning other errors).

Copilot · 2026-04-12T23:18:19Z

+		if err := os.WriteFile(filePath, rewritten, os.ModePerm); err != nil {
+			return fmt.Errorf("write %s: %w", entry.Name(), err)


normalizeUnityRIDTypes rewrites the original raw JSON files in-place (and re-serializes them without preserving formatting). This is a potentially surprising/destructive side effect for a "map" operation. Consider normalizing during parsing, writing normalized copies to a temp/work directory, or scoping the rewrite to files known to require RID normalization.

Copilot · 2026-04-12T23:18:19Z

+	return append([]byte(nil), out...), nil
+}
+
+func unityCropSpriteImage(src image.Image, sprite *uni.Sprite) image.Image {


unityCropSpriteImage is currently unused. If sprites need to be cropped to TextureRect (which this helper suggests), the current export likely writes full textures instead of per-sprite images. Either wire this into the sprite decode/export path or remove the dead code to avoid confusion.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

stelzo · 2026-04-13T11:48:16Z

@copilot apply changes based on the comments in this thread

…g, stat check, in-place normalization, dead code Agent-Logs-Url: https://github.com/dofusdude/doduda/sessions/e8c76188-9498-45ba-a041-9bc8b48959f6 Co-authored-by: stelzo <40026170+stelzo@users.noreply.github.com>

Copilot · 2026-04-13T11:57:49Z

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread in commit 554dbd0:

feedbacks channel blocking (docker:145): guarded sends with if !muteSpinner to prevent deadlock when no consumer goroutine runs
log.Fatalf → return error (docker:170): replaced with return fmt.Errorf("error finishing image handler: %w", err)
UnpackUnityI18n backend routing (update.go:553): added UnpackI18n to the UnityUnpackBackend interface; both native and docker backends implement it (docker delegates to native since there's no Docker container for i18n)
os.Stat error check (images.go:407): changed toErr != nil to errors.Is(toErr, os.ErrNotExist) and added an else if toErr != nil branch to propagate non-ErrNotExist errors
In-place normalization (mapping.go:96): normalizeUnityRIDTypes now takes a dstDir and writes normalized copies there without touching source files; the caller creates a temp dir, passes it for parsing, and defers cleanup
Unused unityCropSpriteImage (unity_imagebundle_native.go:330): removed the function and the now-unused image/draw import

add initial native impl

1800aa4

stelzo requested a review from Copilot April 12, 2026 23:13

Copilot started reviewing on behalf of stelzo April 12, 2026 23:14 View session

Copilot AI reviewed Apr 12, 2026

View reviewed changes

stelzo and others added 3 commits April 13, 2026 13:31

Update unity_backend_docker.go

cc60dc4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update unity_backend_docker.go

ffa4d74

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

inplace test

ac6e2b6

Copilot started work on behalf of stelzo April 13, 2026 11:48 View session

Copilot finished work on behalf of stelzo April 13, 2026 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add initial native impl#117

add initial native impl#117
stelzo wants to merge 5 commits intomainfrom
native-unpack

stelzo commented Apr 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

stelzo commented Apr 13, 2026

Uh oh!

Copilot AI commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if err := os.WriteFile(filePath, rewritten, os.ModePerm); err != nil {
		return fmt.Errorf("write %s: %w", entry.Name(), err)

Conversation

stelzo commented Apr 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

stelzo commented Apr 13, 2026

Uh oh!

Copilot AI commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants